feat: add asset picker opened and selected metrics

.depcheckrc.yml

@@ -18,12 +18,14 @@ ignores:
   - 'typedoc'
   # Ignore plugins for tools
   - '@typescript-eslint/*'
-  - 'babel-jest'
   - 'eslint-config-*'
   - 'eslint-plugin-*'
   - 'jest-silent-reporter'
   - 'prettier-plugin-packagejson'
   - 'typescript-eslint'
+  # Jest environment referenced in `jest.config.scripts.js`
+  - 'jest-environment-node'
+  - 'jest-environment-jsdom'
   # Ignore dependencies imported implicitly by tools
   - 'eslint-import-resolver-typescript'
   # Ignore dependencies which plug into the NPM lifecycle

.github/CODEOWNERS

@@ -49,6 +49,7 @@
 /packages/notification-services-controller     @MetaMask/notifications
 
 ## Perps Team
+/packages/compliance-controller             @MetaMask/perps
 /packages/perps-controller                  @MetaMask/perps
 
 ## Product Safety Team
@@ -108,6 +109,7 @@
 /packages/permission-log-controller             @MetaMask/wallet-integrations @MetaMask/core-platform
 /packages/remote-feature-flag-controller        @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform
 /packages/storage-service                       @MetaMask/extension-platform @MetaMask/mobile-platform @MetaMask/core-platform
+/packages/client-controller                     @MetaMask/core-platform @MetaMask/extension-platform @MetaMask/mobile-platform
 
 ## Package Release related
 /packages/account-tree-controller/package.json  @MetaMask/accounts-engineers @MetaMask/core-platform
@@ -158,6 +160,8 @@
 /packages/name-controller/CHANGELOG.md            @MetaMask/confirmations @MetaMask/core-platform
 /packages/notification-services-controller/package.json @MetaMask/notifications @MetaMask/core-platform
 /packages/notification-services-controller/CHANGELOG.md @MetaMask/notifications @MetaMask/core-platform
+/packages/compliance-controller/package.json   @MetaMask/perps @MetaMask/core-platform
+/packages/compliance-controller/CHANGELOG.md   @MetaMask/perps @MetaMask/core-platform
 /packages/perps-controller/package.json       @MetaMask/perps @MetaMask/core-platform
 /packages/perps-controller/CHANGELOG.md       @MetaMask/perps @MetaMask/core-platform
 /packages/phishing-controller/package.json    @MetaMask/product-safety @MetaMask/core-platform
@@ -203,4 +207,6 @@
 /packages/claims-controller/package.json @MetaMask/web3auth @MetaMask/core-platform
 /packages/claims-controller/CHANGELOG.md @MetaMask/web3auth @MetaMask/core-platform
 /packages/ai-controllers/package.json @MetaMask/social-ai @MetaMask/core-platform
-/packages/ai-controllers/CHANGELOG.md @MetaMask/social-ai @MetaMask/core-platform
+/packages/ai-controllers/CHANGELOG.md @MetaMask/social-ai @MetaMask/core-platform
+/packages/client-controller/package.json @MetaMask/core-platform @MetaMask/extension-platform @MetaMask/mobile-platform
+/packages/client-controller/CHANGELOG.md @MetaMask/core-platform @MetaMask/extension-platform @MetaMask/mobile-platform

AGENTS.md

@@ -151,7 +151,7 @@ Each consumer-facing change to a package should be accompanied by one or more en
     - Fixed
     - Security
 - Within a category section, follow these guidelines:
-  - Highlight breaking changes by prefixing them with `**BREAKING:**`. List breaking changes above non-breaking changes in the same category section.
+  - Highlight breaking changes by prefixing them with `**BREAKING:**`. List breaking changes above non-breaking changes in the same category section. A change is breaking if it removes, renames, or changes the signature of any public export (function, type, class, constant), or changes default behavior that consumers rely on.
   - Omit non-consumer facing changes and reverted changes from the changelog.
   - Use a nested list to add more details about the change if it would help engineers. For breaking changes in particular, highlight steps engineers need to take to adapt to the changes.
   - Each changelog entry should be followed by links to the pull request(s) that introduced the change.

README.md

@@ -37,6 +37,8 @@ Each package in this repository has its own README where you can find installati
 - [`@metamask/build-utils`](packages/build-utils)
 - [`@metamask/chain-agnostic-permission`](packages/chain-agnostic-permission)
 - [`@metamask/claims-controller`](packages/claims-controller)
+- [`@metamask/client-controller`](packages/client-controller)
+- [`@metamask/compliance-controller`](packages/compliance-controller)
 - [`@metamask/composable-controller`](packages/composable-controller)
 - [`@metamask/connectivity-controller`](packages/connectivity-controller)
 - [`@metamask/controller-utils`](packages/controller-utils)
@@ -115,6 +117,8 @@ linkStyle default opacity:0.5
   build_utils(["@metamask/build-utils"]);
   chain_agnostic_permission(["@metamask/chain-agnostic-permission"]);
   claims_controller(["@metamask/claims-controller"]);
+  client_controller(["@metamask/client-controller"]);
+  compliance_controller(["@metamask/compliance-controller"]);
   composable_controller(["@metamask/composable-controller"]);
   connectivity_controller(["@metamask/connectivity-controller"]);
   controller_utils(["@metamask/controller-utils"]);
@@ -181,31 +185,48 @@ linkStyle default opacity:0.5
   address_book_controller --> base_controller;
   address_book_controller --> controller_utils;
   address_book_controller --> messenger;
+  ai_controllers --> base_controller;
+  ai_controllers --> messenger;
   analytics_controller --> base_controller;
   analytics_controller --> messenger;
+  analytics_data_regulation_controller --> base_controller;
+  analytics_data_regulation_controller --> controller_utils;
+  analytics_data_regulation_controller --> messenger;
   announcement_controller --> base_controller;
   announcement_controller --> messenger;
   app_metadata_controller --> base_controller;
   app_metadata_controller --> messenger;
   approval_controller --> base_controller;
   approval_controller --> messenger;
+  assets_controller --> account_tree_controller;
+  assets_controller --> assets_controllers;
   assets_controller --> base_controller;
+  assets_controller --> controller_utils;
+  assets_controller --> core_backend;
+  assets_controller --> keyring_controller;
   assets_controller --> messenger;
+  assets_controller --> network_controller;
+  assets_controller --> network_enablement_controller;
+  assets_controller --> permission_controller;
+  assets_controller --> polling_controller;
+  assets_controller --> preferences_controller;
+  assets_controller --> transaction_controller;
   assets_controllers --> account_tree_controller;
   assets_controllers --> accounts_controller;
   assets_controllers --> approval_controller;
   assets_controllers --> base_controller;
   assets_controllers --> controller_utils;
-  assets_controllers --> core_backend;
   assets_controllers --> keyring_controller;
   assets_controllers --> messenger;
   assets_controllers --> multichain_account_service;
   assets_controllers --> network_controller;
+  assets_controllers --> network_enablement_controller;
   assets_controllers --> permission_controller;
   assets_controllers --> phishing_controller;
   assets_controllers --> polling_controller;
   assets_controllers --> preferences_controller;
   assets_controllers --> profile_sync_controller;
+  assets_controllers --> storage_service;
   assets_controllers --> transaction_controller;
   base_controller --> messenger;
   base_controller --> json_rpc_engine;
@@ -236,6 +257,11 @@ linkStyle default opacity:0.5
   claims_controller --> messenger;
   claims_controller --> keyring_controller;
   claims_controller --> profile_sync_controller;
+  client_controller --> base_controller;
+  client_controller --> messenger;
+  compliance_controller --> base_controller;
+  compliance_controller --> controller_utils;
+  compliance_controller --> messenger;
   composable_controller --> base_controller;
   composable_controller --> messenger;
   composable_controller --> json_rpc_engine;
@@ -412,8 +438,6 @@ linkStyle default opacity:0.5
   subscription_controller --> polling_controller;
   subscription_controller --> profile_sync_controller;
   subscription_controller --> transaction_controller;
-  token_search_discovery_controller --> base_controller;
-  token_search_discovery_controller --> messenger;
   transaction_controller --> accounts_controller;
   transaction_controller --> approval_controller;
   transaction_controller --> base_controller;

eslint-suppressions.json

@@ -249,9 +249,6 @@
     },
     "id-denylist": {
       "count": 1
-    },
-    "import-x/namespace": {
-      "count": 9
     }
   },
   "packages/assets-controllers/src/NftController.ts": {
@@ -341,9 +338,6 @@
     },
     "id-denylist": {
       "count": 2
-    },
-    "import-x/namespace": {
-      "count": 7
     }
   },
   "packages/assets-controllers/src/TokenRatesController.test.ts": {
@@ -372,9 +366,6 @@
   "packages/assets-controllers/src/TokensController.test.ts": {
     "@typescript-eslint/explicit-function-return-type": {
       "count": 6
-    },
-    "import-x/namespace": {
-      "count": 1
     }
   },
   "packages/assets-controllers/src/TokensController.ts": {
@@ -543,14 +534,6 @@
       "count": 3
     }
   },
-  "packages/bridge-controller/src/bridge-controller.test.ts": {
-    "@typescript-eslint/explicit-function-return-type": {
-      "count": 2
-    },
-    "@typescript-eslint/prefer-nullish-coalescing": {
-      "count": 1
-    }
-  },
   "packages/bridge-controller/src/types.ts": {
     "@typescript-eslint/naming-convention": {
       "count": 12
@@ -599,17 +582,6 @@
       "count": 1
     }
   },
-  "packages/bridge-controller/src/utils/fetch.ts": {
-    "@typescript-eslint/explicit-function-return-type": {
-      "count": 1
-    },
-    "@typescript-eslint/prefer-nullish-coalescing": {
-      "count": 8
-    },
-    "id-length": {
-      "count": 1
-    }
-  },
   "packages/bridge-controller/src/utils/metrics/properties.ts": {
     "@typescript-eslint/explicit-function-return-type": {
       "count": 5
@@ -666,37 +638,15 @@
     }
   },
   "packages/bridge-status-controller/src/bridge-status-controller.test.ts": {
-    "@typescript-eslint/explicit-function-return-type": {
-      "count": 15
-    },
     "no-new": {
       "count": 1
     }
   },
-  "packages/bridge-status-controller/src/utils/bridge-status.ts": {
-    "@typescript-eslint/explicit-function-return-type": {
-      "count": 3
-    },
-    "@typescript-eslint/prefer-nullish-coalescing": {
-      "count": 5
-    }
-  },
   "packages/bridge-status-controller/src/utils/gas.ts": {
     "@typescript-eslint/explicit-function-return-type": {
       "count": 4
     }
   },
-  "packages/bridge-status-controller/src/utils/metrics.ts": {
-    "@typescript-eslint/explicit-function-return-type": {
-      "count": 3
-    },
-    "@typescript-eslint/naming-convention": {
-      "count": 4
-    },
-    "camelcase": {
-      "count": 8
-    }
-  },
   "packages/bridge-status-controller/src/utils/snaps.ts": {
     "@typescript-eslint/explicit-function-return-type": {
       "count": 1
@@ -992,9 +942,6 @@
     },
     "@typescript-eslint/naming-convention": {
       "count": 1
-    },
-    "import-x/namespace": {
-      "count": 2
     }
   },
   "packages/gas-fee-controller/src/GasFeeController.ts": {
@@ -1403,9 +1350,6 @@
   "packages/phishing-controller/src/utils.test.ts": {
     "@typescript-eslint/explicit-function-return-type": {
       "count": 2
-    },
-    "import-x/namespace": {
-      "count": 5
     }
   },
   "packages/phishing-controller/src/utils.ts": {

jest.config.packages.js

@@ -89,6 +89,7 @@ module.exports = {
       // so in that case use their published versions
       '<rootDir>/../../node_modules/@metamask/$1',
     ],
+    '^uuid$': require.resolve('uuid'),
   },
 
   // An array of regexp pattern strings, matched against all module paths before considered 'visible' to the module loader
@@ -188,9 +189,6 @@ module.exports = {
   // This option sets the URL for the jsdom environment. It is reflected in properties such as location.href
   // testURL: "http://localhost",
 
-  // Setting this value to "fake" allows the use of fake timers for functions such as "setTimeout"
-  // timers: "real",
-
   // A map from regular expressions to paths to transformers
   // transform: undefined,
 

jest.config.scripts.js

@@ -1,11 +1,6 @@
 /*
  * For a detailed explanation regarding each configuration property and type check, visit:
  * https://jestjs.io/docs/configuration
- *
- * NOTE:
- * This config uses `babel-jest` due to ESM- / TypeScript-related incompatibilities with our
- * current version (`^27`) of `jest` and `ts-jest`. We can switch to `ts-jest` once we have
- * migrated our Jest dependencies to version `>=29`.
  */
 
 module.exports = {
@@ -38,17 +33,11 @@ module.exports = {
     },
   },
 
-  // A map from regular expressions to module names or to arrays of module names that allow to stub out resources with a single module
-  // This ensures that Babel can resolve subpath exports correctly.
   moduleNameMapper: {
-    '^@metamask/utils/(.+)$': [
-      '<rootDir>/node_modules/@metamask/utils/dist/$1.cjs',
-    ],
+    '^uuid$': require.resolve('uuid'),
   },
 
-  // Disabled due to use of 'transform' below.
-  // // A preset that is used as a base for Jest's configuration
-  // preset: 'ts-jest',
+  preset: 'ts-jest',
 
   // The path to the Prettier executable used to format snapshots
   // Jest doesn't support Prettier 3 yet, so we use Prettier 2
@@ -84,9 +73,4 @@ module.exports = {
 
   // Default timeout of a test in milliseconds.
   testTimeout: 5000,
-
-  // A map from regular expressions to paths to transformers
-  transform: {
-    '\\.[jt]sx?$': 'babel-jest',
-  },
 };

package.json

@@ -1,6 +1,6 @@
 {
   "name": "@metamask/core-monorepo",
-  "version": "803.0.0",
+  "version": "822.0.0",
   "private": true,
   "description": "Monorepo for packages shared between MetaMask clients",
   "repository": {
@@ -25,7 +25,7 @@
     "lint": "yarn lint:eslint && echo && yarn lint:misc --check && yarn constraints && yarn lint:dependencies && yarn lint:teams && yarn generate-method-action-types --check",
     "lint:dependencies": "depcheck && yarn dedupe --check",
     "lint:dependencies:fix": "depcheck && yarn dedupe",
-    "lint:eslint": "yarn build:only-clean && yarn eslint",
+    "lint:eslint": "yarn build:only-clean && NODE_OPTIONS='--max-old-space-size=6144' yarn eslint",
     "lint:fix": "yarn lint:eslint --fix --prune-suppressions && echo && yarn lint:misc --write && yarn constraints --fix && yarn lint:dependencies:fix && yarn generate-method-action-types --fix",
     "lint:misc": "prettier --no-error-on-unmatched-pattern '**/*.json' '**/*.md' '**/*.yml' '!.yarnrc.yml' '!merged-packages/**' --ignore-path .gitignore",
     "lint:teams": "tsx scripts/lint-teams-json.ts",
@@ -50,9 +50,6 @@
     "ws@7.4.6": "^7.5.10"
   },
   "devDependencies": {
-    "@babel/core": "^7.23.5",
-    "@babel/plugin-transform-modules-commonjs": "^7.23.3",
-    "@babel/preset-typescript": "^7.23.3",
     "@lavamoat/allow-scripts": "^3.0.4",
     "@lavamoat/preinstall-always-fail": "^2.1.0",
     "@metamask/create-release-branch": "^4.1.4",
@@ -66,14 +63,13 @@
     "@metamask/network-controller": "^29.0.0",
     "@metamask/utils": "^11.9.0",
     "@ts-bridge/cli": "^0.6.4",
-    "@types/jest": "^27.5.2",
+    "@types/jest": "^29.5.14",
     "@types/lodash": "^4.14.191",
     "@types/node": "^16.18.54",
     "@types/semver": "^7",
     "@typescript-eslint/eslint-plugin": "^8.48.0",
     "@typescript-eslint/parser": "^8.48.0",
     "@yarnpkg/types": "^4.0.0",
-    "babel-jest": "^29.7.0",
     "comment-json": "^4.5.1",
     "depcheck": "^1.4.7",
     "eslint": "^9.39.1",
@@ -87,7 +83,7 @@
     "eslint-plugin-promise": "^7.1.0",
     "execa": "^5.0.0",
     "isomorphic-fetch": "^3.0.0",
-    "jest": "^27.5.1",
+    "jest": "^29.7.0",
     "jest-silent-reporter": "^0.5.0",
     "lodash": "^4.17.21",
     "nock": "^13.3.1",
@@ -100,6 +96,7 @@
     "tsx": "^4.20.5",
     "typescript": "~5.3.3",
     "typescript-eslint": "^8.48.0",
+    "uuid": "^8.3.2",
     "yargs": "^17.7.2"
   },
   "packageManager": "yarn@4.10.3",