Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jan 14, 2026

Explanation

Fix suppressed lint errors in @metamask/announcement-controller.

References

Closes #7341

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Fixes a suppressed lint error by enforcing explicit return types in the announcement controller tests.

  • In AnnouncementController.test.ts: add AnnouncementControllerMessenger import and set getMessenger(): AnnouncementControllerMessenger; simplify new Messenger construction with type inference
  • Update eslint-suppressions.json: remove suppression entry for AnnouncementController.test.ts

Written by Cursor Bugbot for commit 2188824. This will update automatically on new commits. Configure here.

Fix suppressed lint errors in `@metamask/announcement-controller`.

Closes #7341
@Gudahtt Gudahtt marked this pull request as ready for review January 14, 2026 16:10
@Gudahtt Gudahtt requested review from a team as code owners January 14, 2026 16:10
@Gudahtt Gudahtt enabled auto-merge January 14, 2026 16:25
@Gudahtt Gudahtt added this pull request to the merge queue Jan 14, 2026
Merged via the queue into main with commit 2887e07 Jan 14, 2026
290 checks passed
@Gudahtt Gudahtt deleted the fix-announcement-controller-suppressed-lint-errors branch January 14, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix suppressed lint errors in announcement-controller

4 participants