refactor: decompose rule decoders, and refactor permission decoding#8730
Open
jeffsmale90 wants to merge 7 commits into
Open
refactor: decompose rule decoders, and refactor permission decoding#8730jeffsmale90 wants to merge 7 commits into
jeffsmale90 wants to merge 7 commits into
Conversation
…rom makePermissionDecoder.
…, just return the config.
…ions from return object
71e997b to
4d784ae
Compare
4d784ae to
98adc20
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f94844b. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
Refactor of permission decoding logic in order to:
decodersrather thanrules- rule is a highly overloaded term)no functional change, therefore no changelog required
References
Checklist
Note
Medium Risk
Refactors the core permission decoding pipeline (type identification and caveat decoding) across multiple permission types, so regressions could change how delegations are classified/decoded even though intent is no functional change.
Overview
Refactors permission decoding from monolithic
PermissionRules toPermissionDecoders built viamakePermissionDecoder, with composableRuleDecoders that independently derive 7715rules(newexpiryRule,nativePayeeRule,erc20PayeeRule,redeemerRule) and hoist expiry.Updates the controller and decode flow APIs (
findDecodersWithMatchingCaveatAddresses,selectUniqueDecoderAndDecodedPermission,createPermissionDecodersForContracts) and removes the oldrules/implementation (makePermissionRule). AddsEXECUTION_PERMISSION_EXPIRY_RULE_TYPE, expands tests to cover the new rule decoders, and marksDecodedPermission.expiryas deprecated in favor ofrules.Reviewed by Cursor Bugbot for commit 1500402. Bugbot is set up for automated code reviews on this repo. Configure here.