This repository was archived by the owner on Jul 31, 2026. It is now read-only.
Repository navigation
test: cover transaction metadata refresh before signing - #305
Merged
gabrieledm merged 1 commit intoMay 20, 2026
Conversation
ulissesferreira
force-pushed
the
NEB-1123-refresh-transaction-metadata
branch
from
May 14, 2026 17:03
0b76de1 to
889e3d0
Compare
ulissesferreira
force-pushed
the
NEB-1123-refresh-transaction-metadata-tests
branch
from
May 14, 2026 17:04
6c8f1b0 to
a2b8262
Compare
ulissesferreira
force-pushed
the
NEB-1123-refresh-transaction-metadata
branch
from
May 14, 2026 17:08
889e3d0 to
4d380e6
Compare
ulissesferreira
force-pushed
the
NEB-1123-refresh-transaction-metadata-tests
branch
from
May 14, 2026 17:09
a2b8262 to
995ddc5
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
This was referenced May 14, 2026
ulissesferreira
force-pushed
the
NEB-1123-refresh-transaction-metadata
branch
from
May 14, 2026 17:31
4d380e6 to
d4386a4
Compare
ulissesferreira
force-pushed
the
NEB-1123-refresh-transaction-metadata-tests
branch
from
May 14, 2026 17:32
995ddc5 to
4b308ec
Compare
ulissesferreira
force-pushed
the
NEB-1123-refresh-transaction-metadata
branch
from
May 14, 2026 17:37
d4386a4 to
9a16d70
Compare
ulissesferreira
force-pushed
the
NEB-1123-refresh-transaction-metadata-tests
branch
from
May 14, 2026 17:37
4b308ec to
92ed0ca
Compare
gabrieledm
merged commit May 20, 2026
20f5407
into
NEB-1123-refresh-transaction-metadata
20 checks passed
pull Bot
pushed a commit
to Dustin4444/metamask-mobile
that referenced
this pull request
May 28, 2026
## Description This PR bumps @metamask/tron-wallet-snap from `^1.25.3` to `^1.25.6`. The main purpose of this update is to pull in the latest Tron snap validation fixes, in particular a mechanism to refresh stale or invalid `expiration`, `ref_block_bytes` and `ref_block_hash` before signing in both send/broadcast paths. Preview package: - `@metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5` Release: - `@metamask-previews/tron-wallet-snap@^1.25.6` Upstream PR: - MetaMask/snap-tron-wallet#305 ## Changelog CHANGELOG entry: bump the `@metamask/tron-wallet-snap` to `^1.25.6` ## Related issues n/a ## Manual testing steps ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## Screenshots/Recordings ### Before <!-- [screenshots/recordings] --> ### After <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches Tron signing and broadcast behavior via the wallet snap; scope is limited to a patch dependency bump with no local code edits, but failed or incorrect ref-block handling could still affect Tron sends. > > **Overview** > Bumps **`@metamask/tron-wallet-snap`** from `^1.25.3` to `^1.25.6` in `package.json` and `yarn.lock`, with an **Unreleased** changelog entry. There are **no application source changes** in this repo—the mobile app picks up upstream snap behavior from the new package version. > > Per the PR intent, **1.25.6** brings Tron transaction validation fixes, notably **refreshing stale or invalid `expiration`, `ref_block_bytes`, and `ref_block_hash` before signing** on send and broadcast paths. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b958d77. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: gabrieledm <gabriele.delmonte@proton.me> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com>
sgextcsi
pushed a commit
to sgextcsi/metamask-extension-ne-regression
that referenced
this pull request
May 28, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR bumps @metamask/tron-wallet-snap from `^1.25.3` to `^1.25.6`. The main purpose of this update is to pull in the latest Tron snap validation fixes, in particular a mechanism to refresh stale or invalid `expiration`, `ref_block_bytes` and `ref_block_hash` before signing in both send/broadcast paths. Preview package: - `@metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5` Release: - `@metamask-previews/tron-wallet-snap@^1.25.6` Upstream PR: - MetaMask/snap-tron-wallet#305 Updated following `e2e` test files to adapt new logic for refresh transaction expiration - `test/e2e/flask/tron-connect/mocks/trongrid.ts` - `test/e2e/flask/tron-connect/common-tron.ts` - `test/e2e/tests/tron/mocks/common-tron.ts` - `test/e2e/flask/tron-connect/signAndSendTrx.spec.ts` - `test/e2e/flask/tron-connect/signAndSendUsdt.spec.ts` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: bump the `@metamask/tron-wallet-snap` to `^1.25.6` ## **Related issues** n/a ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Ships a snap version that changes pre-sign transaction validation/refresh on Tron send paths; risk is mitigated by e2e mock updates but still affects real signing behavior. > > **Overview** > Bumps **`@metamask/tron-wallet-snap`** from `^1.25.3` to **`^1.25.6`** (and lockfile) so the extension picks up upstream fixes that **refresh stale Tron transaction fields** (`expiration`, `ref_block_bytes`, `ref_block_hash`) before sign/broadcast. > > E2E mocks are expanded so tests match that behavior: shared block payloads, new handlers for **`getnowblock`**, **`getblockbynum`**, and Infura **`getnowblock`**; broadcast mocks now return success instead of expiration errors; swap/bridge fixture data uses **future-dated** expirations and aligned ref-block values for stable CI. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit a92c9de. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: gabrieledm <gabriele.delmonte@proton.me> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com> Co-authored-by: Maxime OUAIRY <maxime.ouairy-ext@consensys.net>
runway-github Bot
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
May 28, 2026
## Description This PR bumps @metamask/tron-wallet-snap from `^1.25.3` to `^1.25.6`. The main purpose of this update is to pull in the latest Tron snap validation fixes, in particular a mechanism to refresh stale or invalid `expiration`, `ref_block_bytes` and `ref_block_hash` before signing in both send/broadcast paths. Preview package: - `@metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5` Release: - `@metamask-previews/tron-wallet-snap@^1.25.6` Upstream PR: - MetaMask/snap-tron-wallet#305 ## Changelog CHANGELOG entry: bump the `@metamask/tron-wallet-snap` to `^1.25.6` ## Related issues n/a ## Manual testing steps ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## Screenshots/Recordings ### Before <!-- [screenshots/recordings] --> ### After <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches Tron signing and broadcast behavior via the wallet snap; scope is limited to a patch dependency bump with no local code edits, but failed or incorrect ref-block handling could still affect Tron sends. > > **Overview** > Bumps **`@metamask/tron-wallet-snap`** from `^1.25.3` to `^1.25.6` in `package.json` and `yarn.lock`, with an **Unreleased** changelog entry. There are **no application source changes** in this repo—the mobile app picks up upstream snap behavior from the new package version. > > Per the PR intent, **1.25.6** brings Tron transaction validation fixes, notably **refreshing stale or invalid `expiration`, `ref_block_bytes`, and `ref_block_hash` before signing** on send and broadcast paths. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b958d77. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: gabrieledm <gabriele.delmonte@proton.me> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com>
runway-github Bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
May 28, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR bumps @metamask/tron-wallet-snap from `^1.25.3` to `^1.25.6`. The main purpose of this update is to pull in the latest Tron snap validation fixes, in particular a mechanism to refresh stale or invalid `expiration`, `ref_block_bytes` and `ref_block_hash` before signing in both send/broadcast paths. Preview package: - `@metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5` Release: - `@metamask-previews/tron-wallet-snap@^1.25.6` Upstream PR: - MetaMask/snap-tron-wallet#305 Updated following `e2e` test files to adapt new logic for refresh transaction expiration - `test/e2e/flask/tron-connect/mocks/trongrid.ts` - `test/e2e/flask/tron-connect/common-tron.ts` - `test/e2e/tests/tron/mocks/common-tron.ts` - `test/e2e/flask/tron-connect/signAndSendTrx.spec.ts` - `test/e2e/flask/tron-connect/signAndSendUsdt.spec.ts` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: bump the `@metamask/tron-wallet-snap` to `^1.25.6` ## **Related issues** n/a ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Ships a snap version that changes pre-sign transaction validation/refresh on Tron send paths; risk is mitigated by e2e mock updates but still affects real signing behavior. > > **Overview** > Bumps **`@metamask/tron-wallet-snap`** from `^1.25.3` to **`^1.25.6`** (and lockfile) so the extension picks up upstream fixes that **refresh stale Tron transaction fields** (`expiration`, `ref_block_bytes`, `ref_block_hash`) before sign/broadcast. > > E2E mocks are expanded so tests match that behavior: shared block payloads, new handlers for **`getnowblock`**, **`getblockbynum`**, and Infura **`getnowblock`**; broadcast mocks now return success instead of expiration errors; swap/bridge fixture data uses **future-dated** expirations and aligned ref-block values for stable CI. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit a92c9de. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: gabrieledm <gabriele.delmonte@proton.me> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com> Co-authored-by: Maxime OUAIRY <maxime.ouairy-ext@consensys.net>
runway-github Bot
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
May 28, 2026
## Description This PR bumps @metamask/tron-wallet-snap from `^1.25.3` to `^1.25.6`. The main purpose of this update is to pull in the latest Tron snap validation fixes, in particular a mechanism to refresh stale or invalid `expiration`, `ref_block_bytes` and `ref_block_hash` before signing in both send/broadcast paths. Preview package: - `@metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5` Release: - `@metamask-previews/tron-wallet-snap@^1.25.6` Upstream PR: - MetaMask/snap-tron-wallet#305 ## Changelog CHANGELOG entry: bump the `@metamask/tron-wallet-snap` to `^1.25.6` ## Related issues n/a ## Manual testing steps ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## Screenshots/Recordings ### Before <!-- [screenshots/recordings] --> ### After <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches Tron signing and broadcast behavior via the wallet snap; scope is limited to a patch dependency bump with no local code edits, but failed or incorrect ref-block handling could still affect Tron sends. > > **Overview** > Bumps **`@metamask/tron-wallet-snap`** from `^1.25.3` to `^1.25.6` in `package.json` and `yarn.lock`, with an **Unreleased** changelog entry. There are **no application source changes** in this repo—the mobile app picks up upstream snap behavior from the new package version. > > Per the PR intent, **1.25.6** brings Tron transaction validation fixes, notably **refreshing stale or invalid `expiration`, `ref_block_bytes`, and `ref_block_hash` before signing** on send and broadcast paths. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b958d77. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: gabrieledm <gabriele.delmonte@proton.me> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com>
runway-github Bot
added a commit
to MetaMask/metamask-extension
that referenced
this pull request
May 28, 2026
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR bumps @metamask/tron-wallet-snap from `^1.25.3` to `^1.25.6`. The main purpose of this update is to pull in the latest Tron snap validation fixes, in particular a mechanism to refresh stale or invalid `expiration`, `ref_block_bytes` and `ref_block_hash` before signing in both send/broadcast paths. Preview package: - `@metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5` Release: - `@metamask-previews/tron-wallet-snap@^1.25.6` Upstream PR: - MetaMask/snap-tron-wallet#305 Updated following `e2e` test files to adapt new logic for refresh transaction expiration - `test/e2e/flask/tron-connect/mocks/trongrid.ts` - `test/e2e/flask/tron-connect/common-tron.ts` - `test/e2e/tests/tron/mocks/common-tron.ts` - `test/e2e/flask/tron-connect/signAndSendTrx.spec.ts` - `test/e2e/flask/tron-connect/signAndSendUsdt.spec.ts` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: bump the `@metamask/tron-wallet-snap` to `^1.25.6` ## **Related issues** n/a ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Ships a snap version that changes pre-sign transaction validation/refresh on Tron send paths; risk is mitigated by e2e mock updates but still affects real signing behavior. > > **Overview** > Bumps **`@metamask/tron-wallet-snap`** from `^1.25.3` to **`^1.25.6`** (and lockfile) so the extension picks up upstream fixes that **refresh stale Tron transaction fields** (`expiration`, `ref_block_bytes`, `ref_block_hash`) before sign/broadcast. > > E2E mocks are expanded so tests match that behavior: shared block payloads, new handlers for **`getnowblock`**, **`getblockbynum`**, and Infura **`getnowblock`**; broadcast mocks now return success instead of expiration errors; swap/bridge fixture data uses **future-dated** expirations and aligned ref-block values for stable CI. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit a92c9de. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: gabrieledm <gabriele.delmonte@proton.me> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com> Co-authored-by: Maxime OUAIRY <maxime.ouairy-ext@consensys.net>
runway-github Bot
added a commit
to MetaMask/metamask-mobile
that referenced
this pull request
May 28, 2026
## Description This PR bumps @metamask/tron-wallet-snap from `^1.25.3` to `^1.25.6`. The main purpose of this update is to pull in the latest Tron snap validation fixes, in particular a mechanism to refresh stale or invalid `expiration`, `ref_block_bytes` and `ref_block_hash` before signing in both send/broadcast paths. Preview package: - `@metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5` Release: - `@metamask-previews/tron-wallet-snap@^1.25.6` Upstream PR: - MetaMask/snap-tron-wallet#305 ## Changelog CHANGELOG entry: bump the `@metamask/tron-wallet-snap` to `^1.25.6` ## Related issues n/a ## Manual testing steps ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## Screenshots/Recordings ### Before <!-- [screenshots/recordings] --> ### After <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches Tron signing and broadcast behavior via the wallet snap; scope is limited to a patch dependency bump with no local code edits, but failed or incorrect ref-block handling could still affect Tron sends. > > **Overview** > Bumps **`@metamask/tron-wallet-snap`** from `^1.25.3` to `^1.25.6` in `package.json` and `yarn.lock`, with an **Unreleased** changelog entry. There are **no application source changes** in this repo—the mobile app picks up upstream snap behavior from the new package version. > > Per the PR intent, **1.25.6** brings Tron transaction validation fixes, notably **refreshing stale or invalid `expiration`, `ref_block_bytes`, and `ref_block_hash` before signing** on send and broadcast paths. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b958d77. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: gabrieledm <gabriele.delmonte@proton.me> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com>
vpintorico
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
May 28, 2026
… to `1.25.6` (#43038) - chore: bump `@metamask/tron-wallet-snap` to `1.25.6` (#42701) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR bumps @metamask/tron-wallet-snap from `^1.25.3` to `^1.25.6`. The main purpose of this update is to pull in the latest Tron snap validation fixes, in particular a mechanism to refresh stale or invalid `expiration`, `ref_block_bytes` and `ref_block_hash` before signing in both send/broadcast paths. Preview package: - `@metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5` Release: - `@metamask-previews/tron-wallet-snap@^1.25.6` Upstream PR: - MetaMask/snap-tron-wallet#305 Updated following `e2e` test files to adapt new logic for refresh transaction expiration - `test/e2e/flask/tron-connect/mocks/trongrid.ts` - `test/e2e/flask/tron-connect/common-tron.ts` - `test/e2e/tests/tron/mocks/common-tron.ts` - `test/e2e/flask/tron-connect/signAndSendTrx.spec.ts` - `test/e2e/flask/tron-connect/signAndSendUsdt.spec.ts` ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: bump the `@metamask/tron-wallet-snap` to `^1.25.6` ## **Related issues** n/a ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Ships a snap version that changes pre-sign transaction validation/refresh on Tron send paths; risk is mitigated by e2e mock updates but still affects real signing behavior. > > **Overview** > Bumps **`@metamask/tron-wallet-snap`** from `^1.25.3` to **`^1.25.6`** (and lockfile) so the extension picks up upstream fixes that **refresh stale Tron transaction fields** (`expiration`, `ref_block_bytes`, `ref_block_hash`) before sign/broadcast. > > E2E mocks are expanded so tests match that behavior: shared block payloads, new handlers for **`getnowblock`**, **`getblockbynum`**, and Infura **`getnowblock`**; broadcast mocks now return success instead of expiration errors; swap/bridge fixture data uses **future-dated** expirations and aligned ref-block values for stable CI. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit a92c9de. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: gabrieledm <gabriele.delmonte@proton.me> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com> Co-authored-by: Maxime OUAIRY <maxime.ouairy-ext@consensys.net> [4d85bd5](4d85bd5) --------- Co-authored-by: Ulisses Ferreira <ulisses@hey.com> Co-authored-by: gabrieledm <gabriele.delmonte@proton.me> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com> Co-authored-by: Maxime OUAIRY <maxime.ouairy-ext@consensys.net> Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
matthewwalsh0
pushed a commit
to MetaMask/metamask-extension
that referenced
this pull request
May 29, 2026
… to `1.25.6` (#43038) - chore: bump `@metamask/tron-wallet-snap` to `1.25.6` (#42701) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR bumps @metamask/tron-wallet-snap from `^1.25.3` to `^1.25.6`. The main purpose of this update is to pull in the latest Tron snap validation fixes, in particular a mechanism to refresh stale or invalid `expiration`, `ref_block_bytes` and `ref_block_hash` before signing in both send/broadcast paths. Preview package: - `@metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5` Release: - `@metamask-previews/tron-wallet-snap@^1.25.6` Upstream PR: - MetaMask/snap-tron-wallet#305 Updated following `e2e` test files to adapt new logic for refresh transaction expiration - `test/e2e/flask/tron-connect/mocks/trongrid.ts` - `test/e2e/flask/tron-connect/common-tron.ts` - `test/e2e/tests/tron/mocks/common-tron.ts` - `test/e2e/flask/tron-connect/signAndSendTrx.spec.ts` - `test/e2e/flask/tron-connect/signAndSendUsdt.spec.ts` <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: bump the `@metamask/tron-wallet-snap` to `^1.25.6` n/a 1. Go to this page... 2. 3. <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> <!-- [screenshots/recordings] --> <!-- [screenshots/recordings] --> - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Ships a snap version that changes pre-sign transaction validation/refresh on Tron send paths; risk is mitigated by e2e mock updates but still affects real signing behavior. > > **Overview** > Bumps **`@metamask/tron-wallet-snap`** from `^1.25.3` to **`^1.25.6`** (and lockfile) so the extension picks up upstream fixes that **refresh stale Tron transaction fields** (`expiration`, `ref_block_bytes`, `ref_block_hash`) before sign/broadcast. > > E2E mocks are expanded so tests match that behavior: shared block payloads, new handlers for **`getnowblock`**, **`getblockbynum`**, and Infura **`getnowblock`**; broadcast mocks now return success instead of expiration errors; swap/bridge fixture data uses **future-dated** expirations and aligned ref-block values for stable CI. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit a92c9de. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: gabrieledm <gabriele.delmonte@proton.me> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com> Co-authored-by: Maxime OUAIRY <maxime.ouairy-ext@consensys.net> [4d85bd5](4d85bd5) --------- Co-authored-by: Ulisses Ferreira <ulisses@hey.com> Co-authored-by: gabrieledm <gabriele.delmonte@proton.me> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com> Co-authored-by: Maxime OUAIRY <maxime.ouairy-ext@consensys.net> Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
samir-acle
pushed a commit
to MetaMask/metamask-mobile
that referenced
this pull request
May 29, 2026
## Description This PR bumps @metamask/tron-wallet-snap from `^1.25.3` to `^1.25.6`. The main purpose of this update is to pull in the latest Tron snap validation fixes, in particular a mechanism to refresh stale or invalid `expiration`, `ref_block_bytes` and `ref_block_hash` before signing in both send/broadcast paths. Preview package: - `@metamask-previews/tron-wallet-snap@1.25.3-preview-995ddc5` Release: - `@metamask-previews/tron-wallet-snap@^1.25.6` Upstream PR: - MetaMask/snap-tron-wallet#305 ## Changelog CHANGELOG entry: bump the `@metamask/tron-wallet-snap` to `^1.25.6` ## Related issues n/a ## Manual testing steps ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## Screenshots/Recordings ### Before <!-- [screenshots/recordings] --> ### After <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** <!-- Every checklist item must be consciously assessed before marking this PR as "Ready for review". A checked box means you deliberately considered that responsibility, not that you literally performed every action listed. Unchecked boxes are ambiguous: they are not an implicit "N/A" and they are not a silent "skip". See `docs/readme/ready-for-review.md` for the full checklist semantics. --> - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [ ] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [ ] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [ ] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** <!-- Reviewer checklist items follow the same semantics as the author checklist: an unchecked box is ambiguous, a checked box means the reviewer consciously assessed that responsibility. See `docs/readme/ready-for-review.md`. --> - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Touches Tron signing and broadcast behavior via the wallet snap; scope is limited to a patch dependency bump with no local code edits, but failed or incorrect ref-block handling could still affect Tron sends. > > **Overview** > Bumps **`@metamask/tron-wallet-snap`** from `^1.25.3` to `^1.25.6` in `package.json` and `yarn.lock`, with an **Unreleased** changelog entry. There are **no application source changes** in this repo—the mobile app picks up upstream snap behavior from the new package version. > > Per the PR intent, **1.25.6** brings Tron transaction validation fixes, notably **refreshing stale or invalid `expiration`, `ref_block_bytes`, and `ref_block_hash` before signing** on send and broadcast paths. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit b958d77. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> --------- Co-authored-by: gabrieledm <gabriele.delmonte@proton.me> Co-authored-by: Gabriele Del Monte <37625739+gabrieledm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification