feat: solves issue with short readable label field by excluding amounts in readable#45
Merged
Merged
Conversation
erwolff
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the V6 transaction categorization test snapshots to simplify the
readabledescriptions for various transaction types. The new format omits the specific token amounts, focusing instead on the token names and transaction actions. This change improves consistency and readability across transaction summaries.Snapshot readable string simplification:
readablefields intxCategorize.test.ts.snapwere updated to remove specific token amounts, now only showing the token names and action (e.g., "Swapped ETH for Bonk" instead of "Swapped 0.0264 ETH for 3.04M Bonk"). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19] [20] [21] [22] [23] [24] [25] [26] [27] [28] [29] [30] [31] [32] [33]No logic changes were made—these are updates to test snapshots only, reflecting the new, more concise output format.
Note
Medium Risk
Changes the V6 transaction metadata output format by removing amounts from
readableand introducing a newreadableExtendedfield; downstream consumers or tests relying on the oldreadablestring may need updates.Overview
V6 transaction categorization now produces two human-readable strings: a shorter
readablethat omits asset amounts (e.g. “Swapped ETH for USDC”) and a newreadableExtendedthat preserves the previous amount-inclusive phrasing.This is implemented by extending template interpolation to optionally suppress
$*_valuesubstitutions and by updating V6 fallback metadata and tests/snapshots to assert againstreadableExtendedwhile snapshotting the simplifiedreadableoutput.Reviewed by Cursor Bugbot for commit 962f6aa. Bugbot is set up for automated code reviews on this repo. Configure here.