Skip to content

feat: solves issue with short readable label field by excluding amounts in readable#45

Merged
blurpesec merged 1 commit into
mainfrom
feat/reduce-readable-length
May 5, 2026
Merged

feat: solves issue with short readable label field by excluding amounts in readable#45
blurpesec merged 1 commit into
mainfrom
feat/reduce-readable-length

Conversation

@blurpesec
Copy link
Copy Markdown
Contributor

@blurpesec blurpesec commented May 4, 2026

This pull request updates the V6 transaction categorization test snapshots to simplify the readable descriptions for various transaction types. The new format omits the specific token amounts, focusing instead on the token names and transaction actions. This change improves consistency and readability across transaction summaries.

Snapshot readable string simplification:

No logic changes were made—these are updates to test snapshots only, reflecting the new, more concise output format.


Note

Medium Risk
Changes the V6 transaction metadata output format by removing amounts from readable and introducing a new readableExtended field; downstream consumers or tests relying on the old readable string may need updates.

Overview
V6 transaction categorization now produces two human-readable strings: a shorter readable that omits asset amounts (e.g. “Swapped ETH for USDC”) and a new readableExtended that preserves the previous amount-inclusive phrasing.

This is implemented by extending template interpolation to optionally suppress $*_value substitutions and by updating V6 fallback metadata and tests/snapshots to assert against readableExtended while snapshotting the simplified readable output.

Reviewed by Cursor Bugbot for commit 962f6aa. Bugbot is set up for automated code reviews on this repo. Configure here.

@blurpesec blurpesec requested a review from a team as a code owner May 4, 2026 21:49
@blurpesec blurpesec merged commit 76ce171 into main May 5, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants