feat: remove spender in approval readable label#48
Merged
Conversation
erwolff
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: changes are limited to localization strings and test expectations for
APPROVEtransactions, with no transaction categorization logic modified.Overview
Updates the localizationV2
APPROVEtemplate across all supported locales to remove the spender address and render approvals asApprove ... spending cap.Adjusts V6 snapshots and unit/integration tests (
utils.test.ts,localizationV2/index.test.ts,txCategorize.test.ts,testCases.mock.ts) to expect the new approval wording for ERC-20/721, WETH, ENS, and Compound approval cases.Reviewed by Cursor Bugbot for commit 0cb9f1e. Bugbot is set up for automated code reviews on this repo. Configure here.