Generate the concrete numeric OO surfaces - #81
Merged
estebanzimanyi merged 1 commit intoJul 23, 2026
Merged
Conversation
Add GeneratedTInt, GeneratedTFloat and GeneratedTBigint, each extending GeneratedTNumber, for the base-typed number-temporal methods. The concrete base value type comes from the catalog — int for tint, double for tfloat, int64 for tbigint — so the base accessors (minValue, maxValue, startValue, endValue), the base-valued arguments (atValue, minusValue, shiftValue, scaleValue, shiftScaleValue), the conversions (toTfloat, toTint, toTbigint, fromBaseTemp), the input/output methods and the tfloat math accessors marshal through the existing scalar and temporal paths with no per-class configuration. A Span array return is a value-span array on these surfaces, whose concrete span type is base-dependent, so it is held for a later slice alongside the value-set returns and the value splits. A parity test checks the int and float surfaces against direct GeneratedFunctions calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
GeneratedTInt,GeneratedTFloatandGeneratedTBigint, each extendingGeneratedTNumber, for the base-typed number-temporal methods.The concrete base value type comes from the catalog —
intfor tint,doublefor tfloat,int64for tbigint — so the base accessors (minValue,maxValue,startValue,endValue), the base-valued arguments (atValue,minusValue,shiftValue,scaleValue,shiftScaleValue), the conversions (toTfloat,toTint,toTbigint,fromBaseTemp), the input/output methods and the tfloat math accessors marshal through the existing scalar and temporal paths with no per-class configuration.A
Spanarray return is a value-span array on these surfaces, whose concrete span type is base-dependent, so it is held for a later slice alongside the value-set returns and the value splits. A parity test checks the int and float surfaces against directGeneratedFunctionscalls.