Generate the TNumber base-value accessors#83
Merged
estebanzimanyi merged 1 commit intoJul 23, 2026
Merged
Conversation
The value-at-n and value-at-timestamp accessors of tint and tfloat return the base value through a boolean-plus-result out-parameter, which the converter covered only for timestamps. Extend the bool-plus-result converter to the base scalar out-parameters, so valueN and valueAtTimestamptz fold to the boxed base value (int or double), or null when the boolean reports no value. The converter reads the concrete element type from the catalog, so no per-class configuration is needed. A parity test checks valueN and valueAtTimestamptz against direct GeneratedFunctions calls.
estebanzimanyi
force-pushed
the
feat/generate-tnumber-value-accessors
branch
from
July 23, 2026 13:46
b87c512 to
cf50338
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value-at-n and value-at-timestamp accessors of tint and tfloat return the base value through a boolean-plus-result out-parameter, which the converter covered only for timestamps.
This extends the bool-plus-result converter to the base scalar out-parameters, so
valueNandvalueAtTimestamptzfold to the boxed base value (intordouble), or null when the boolean reports no value. The converter reads the concrete element type from the catalog, so no per-class configuration is needed.A parity test checks
valueNandvalueAtTimestamptzagainst directGeneratedFunctionscalls.The value-collection returns —
getValues, whose canonical form is the value spansettnumber_valuespans(intspanset/floatspanset), and the rawvaluesarray — remain for a later slice, since their concrete element type is a base-dependent wrapper.