Generate temporal_hash_extended over all temporal families - #226
Closed
estebanzimanyi wants to merge 2 commits into
Closed
Generate temporal_hash_extended over all temporal families#226estebanzimanyi wants to merge 2 commits into
estebanzimanyi wants to merge 2 commits into
Conversation
…ical Regenerates the generated UDF surface from MobilityDB master (which brings in the generic temporal_hash surface). The MEOS-API catalog now renders the uint32 canonical type as `unsigned int` (it was `uint32_t`); key the scalar type maps on it so the *_hash functions keep registering instead of being dropped. uint32 hashes map to DuckDB's native `UINTEGER`, not a signed `INTEGER` — a hash >= 2**31 is out of range for INT32 and DuckDB range-checks the cast rather than bit-reinterpreting the way PostgreSQL/C do; DuckDB has real unsigned SQL types, so `UINTEGER` is the faithful representation.
Generates the extended (64-bit, seeded) hash `temporal_hash_extended(<ttype>, UBIGINT)` for every temporal family, inherited through Temporal<T> — the Duck side of the MEOS temporal_hash_extended surface. The uint64 hash and its seed use DuckDB's native `UBIGINT`, not a signed BIGINT: a MEOS hash fills the full unsigned range (e.g. temporal_hash_extended(tint '1@2000-01-01', 0) = 11445401048662056440, which is > 2**63 and does not fit in a signed BIGINT), and DuckDB range-checks the cast rather than bit-reinterpreting the way PostgreSQL/C do. Generator: key uint64_t to UBIGINT in the scalar arg/return maps (SCALAR, SCALAR_ARG, SCALAR_RET_CPP), and check the Tcell cell-id branch before the generic scalar branch in ret_type and shape_emittable so a uint64 cell id keeps its cell type instead of collapsing to UBIGINT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generates the extended (64-bit, seeded) hash
temporal_hash_extended(<ttype>, UBIGINT)for every temporal family, inherited throughTemporal<T>— the Duck side of the MEOStemporal_hash_extendedsurface.The uint64 hash and its seed use DuckDB's native
UBIGINT, not a signedBIGINT: a MEOS hash fills the full unsigned range. For exampletemporal_hash_extended(tint '1@2000-01-01', 0)=11445401048662056440, which is greater than 2**63 and does not fit in a signedBIGINT; DuckDB range-checks the cast rather than bit-reinterpreting the way PostgreSQL/C do.temporal_hash(uint32) analogously staysUINTEGER.uint64_ttoUBIGINTin the scalar arg/return maps (SCALAR,SCALAR_ARG,SCALAR_RET_CPP), so the existing(Temporal, scalar)->scalarbinary shape emits it.Tcellcell-id branch before the generic scalar branch inret_typeandshape_emittable, so a uint64 cell id keeps its cell type (th3index/tquadbinstartValue) instead of collapsing toUBIGINT.test/sql/temporal_hash.test:temporal_hash(UINTEGER) andtemporal_hash_extended(UBIGINT, seed-sensitive, full uint64 range) across temporal families.