Name no way to skip the tests - #55
Merged
estebanzimanyi merged 1 commit intoAug 31, 2026
Merged
Conversation
`tools/refresh-from-master.sh` forwards to MEOS-API's `refresh-binding.sh`, which
carries no `--skip-tests`: passing it is an error, not a faster refresh.
GENERATION.md offered it as a usage example and `refresh.conf` expanded
`${SKIP_TESTS:+-DskipTests}` into the build command against a variable nothing
sets. The comment says instead what the suite is for — telling a regenerated
surface from a merely well-formed one.
`-DskipTests` goes from the two benchmark images and from `run_query.sh` as
well, so no recipe here shows a reader how to get an artifact without running
the suite that says the artifact answers. ⚠️ Neither image builds from a clean
checkout, for reasons that stand either way: `DockerfileSQL` copies
`benchmark/jar/JMEOS.jar`, which the repository does not track, and answers
`COPY failed: ... file does not exist`; `Dockerfile_q8_meos_kalman` clones a
personal MobilityDB fork and a JMEOS feature branch. The libmeos stage of
`DockerfileSQL` builds green.
A full `tools/refresh-from-master.sh` runs green: 7 binding and 12 benchmark
tests, 0 skipped.
estebanzimanyi
deleted the
chore/no-skip-tests-option-the-chain-refuses
branch
August 31, 2026 19:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tools/refresh-from-master.shforwards to MEOS-API'srefresh-binding.sh, whichcarries no
--skip-tests: passing it is an error, not a faster refresh.GENERATION.md offered it as a usage example and
refresh.confexpanded${SKIP_TESTS:+-DskipTests}into the build command against a variable nothingsets. The comment says instead what the suite is for — telling a regenerated
surface from a merely well-formed one.
-DskipTestsgoes from the two benchmark images and fromrun_query.shaswell, so no recipe here shows a reader how to get an artifact without running
the suite that says the artifact answers.
checkout, for reasons that stand either way:
DockerfileSQLcopiesbenchmark/jar/JMEOS.jar, which the repository does not track, and answersCOPY failed: ... file does not exist;Dockerfile_q8_meos_kalmanclones apersonal MobilityDB fork and a JMEOS feature branch. The libmeos stage of
DockerfileSQLbuilds green.A full
tools/refresh-from-master.shruns green: 7 binding and 12 benchmarktests, 0 skipped.