Drop the per-query Dockerfile lookup nothing selects - #60
Merged
estebanzimanyi merged 1 commit intoSep 1, 2026
Merged
Conversation
`run_query.sh` chose the image per query through a `QUERY_DOCKERFILE` map, which existed for the one query that needed its own image. That image is gone — `Dockerfile_q8_meos_kalman` collapsed into the base one when the MEOS entry it patched turned out to be upstream — so all nine entries are empty, `CUSTOM_DF` is always the empty string, and `BASE_DOCKERFILE` always resolves to `Dockerfile`. The map, the lookup and the fallback go; `BASE_DOCKERFILE` names the one image directly. Every query builds it and differs only in the entrypoint class, which the `sed` patch below already supplies.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_query.shchose the image per query through aQUERY_DOCKERFILEmap, whichexisted for the one query that needed its own image. That image is gone —
Dockerfile_q8_meos_kalmancollapsed into the base one when the MEOS entry itpatched turned out to be upstream — so all nine entries are empty,
CUSTOM_DFisalways the empty string, and
BASE_DOCKERFILEalways resolves toDockerfile.The map, the lookup and the fallback go;
BASE_DOCKERFILEnames the one imagedirectly. Every query builds it and differs only in the entrypoint class, which
the
sedpatch below already supplies.