[Fix] Keep Buffer input validation active under python -O - #11
Open
morluto wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1.
Summary
Replace correctness-critical assertions at the public
Bufferboundary withtyped exceptions that remain active under
python -O.Problem
Python removes
assertstatements when optimization is enabled. Public checksfor tensor dtype, shape, contiguity, device placement, required arguments, and
zero-copy aliasing could therefore disappear before malformed inputs reached
CUDA-facing code.
Change
Add a shared public tensor validator covering:
Apply explicit validation to:
The exception types distinguish the failure category:
TypeErrorfor incorrect Python types and tensor dtypes;ValueErrorfor incompatible shapes, layouts, devices, arguments, andaliases;
RuntimeErrorfor destroyed or uninitialized buffers.Scope
This PR covers the top-level
BufferAPI inapi.py. Internal launch-timeassertions in planning, dispatch, combine, buffer allocation, and
gradient-reduction modules remain separate work under #1.
It does not include the separate
num_smspolicy or communication-planprovenance changes.
Validation
python -O— passed.gradient reduction, and zero-copy aliasing.