fix(web): surface session list load failures#1641
Conversation
🦋 Changeset detectedLatest commit: edfdc2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@codex review |
commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68afe97e63
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61bbb47cae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 15053502bc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| for (const session of rawState.sessions) { | ||
| if (loadedIds.has(session.id)) continue; | ||
| merged.push(session); |
There was a problem hiding this comment.
When a later /sessions page fails, this loop appends every cached session that was not returned by the successful prefix. The first page is already authoritative for the newest range it covers; if a cached session in that range was deleted, archived, or became empty on the server, it is absent from sessions but gets added back here, so the no-workspace fallback or loadAllSessions can keep showing stale rows until a full drain eventually succeeds. Only cached rows older than the oldest successfully fetched row should be retained as unreached.
Useful? React with 👍 / 👎.
wbxl2000
force-pushed
the
codex/fix-kimi-web-session-load-errors
branch
3 times, most recently
from
83c2739 to
edfdc2b
Compare
1 participant
Related Issue
None. This is a focused fix for a reproducible session-list loading failure.
Problem
Kimi Web converted both the no-workspace session fallback failure and per-workspace initial-page failures into successful empty results. Users could therefore see an empty session list with no error, and a refresh could discard sessions that were already loaded from a workspace whose request failed.
What changed
Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.