chore: split web and desktop apps out to the code-app repo#1733
chore: split web and desktop apps out to the code-app repo#1733liruifengv wants to merge 2 commits into
Conversation
Remove the apps/kimi-web and apps/kimi-desktop sources, which now live in the code-app repo. - Drop the kimi-web build step and copy-web-assets.mjs from the package build; apps/kimi-code/dist-web becomes a committed artifact synced from code-app (follow-up change). - Remove the desktop release CI (desktop-build.yml, the desktop-artifacts release job) and the root dev:web / dev:desktop scripts. - Drop electron from onlyBuiltDependencies; nothing in the workspace depends on it anymore. - smoke.mjs no longer asserts dist-web exists; restore the assertion once the committed artifact lands. - Update the flake.nix workspace lists, the AGENTS.md project map, and the changeset README package list.
🦋 Changeset detectedLatest commit: a9bc43c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
|
❌ Nix build failed Hash mismatch in
Please update |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a9bc43cb80
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
| "scripts": { | ||
| "build": "pnpm -C ../kimi-web run build && tsdown && node scripts/copy-native-assets.mjs && node scripts/copy-web-assets.mjs", | ||
| "build": "tsdown && node scripts/copy-native-assets.mjs", |
There was a problem hiding this comment.
In a clean checkout of this commit, apps/kimi-code/dist-web is not tracked, and this build script no longer creates it. The server still falls back to apps/kimi-code/dist-web outside SEA mode and kap-server rejects startup when index.html is absent; the SEA build's collectWebAssets also fails before producing native artifacts. Please keep generating/copying the web bundle here, or add the committed artifact in the same change, so kimi web, pkg.pr previews, release, and Nix/native builds do not run or ship without web assets.
Useful? React with 👍 / 👎.
1 participant
Related Issue
No tracking issue — the problem is explained below. Pairs with #1732.
Problem
The web UI and the Electron desktop app are now developed in the code-app repo (
apps/web/apps/desktopthere). Keeping their sources in this repo means two diverging copies and a release pipeline that rebuilds artifacts the other repo owns.What changed
apps/kimi-webandapps/kimi-desktopsources (-65k lines).copy-web-assets.mjsremoved). dist-web ships as a committed artifact synced from code-app — that is chore: track dist-web web bundle as a committed artifact #1732.desktop-build.yml, thedesktop-artifactsrelease job) and the rootdev:web/dev:desktopscripts; droponlyBuiltDependencies: electron(nothing left in the workspace depends on electron).smoke.mjsstops asserting that dist-web exists so CI passes before chore: track dist-web web bundle as a committed artifact #1732 lands; the assertion can be restored afterwards._native-build.yml, pkg-pr-new.yml, the docker e2e node_modules mounts, the AGENTS.md project map, and the changeset README package list.Merge note: the SEA native build and the Nix build embed
apps/kimi-code/dist-weband fail if it is missing, so land #1732 together with (or before) this PR, and avoid cutting a release in between.Checklist
pnpm install, CLItsc --noEmit,check-nix-workspace,sherif, and a fullpnpm buildall pass.)gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update. (User-facing docs are unaffected:kimi webbehavior is unchanged once chore: track dist-web web bundle as a committed artifact #1732 lands.)