Skip to content

add parser accepting string config#285

Merged
K20shores merged 6 commits into
mainfrom
string_config_parser
Jun 30, 2026
Merged

add parser accepting string config#285
K20shores merged 6 commits into
mainfrom
string_config_parser

Conversation

@K20shores

@K20shores K20shores commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

musica needs to be able to parse string content. When I moved the v1 parser from public to private headers, I removed that capability. This adds it back

  • make fmt a private implementation header in detail
  • make v0 translate each reaction type to it's corresponding reaction type and not translating to user defined (where applicable), not adding PHOTO., LOSS., USER., EMIS.

@K20shores K20shores requested a review from boulderdaze June 29, 2026 12:09
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.93%. Comparing base (04d2f08) to head (842f7d3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/parse.cpp 61.53% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #285       +/-   ##
===========================================
+ Coverage   31.57%   88.93%   +57.35%     
===========================================
  Files           4       38       +34     
  Lines          19     1627     +1608     
===========================================
+ Hits            6     1447     +1441     
- Misses         13      180      +167     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@K20shores K20shores merged commit fc9d358 into main Jun 30, 2026
28 of 29 checks passed
@K20shores K20shores deleted the string_config_parser branch June 30, 2026 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants