Skip to content

Comments

CCM-12685: Validate routing config submit and move child templates to SUBMITTED#806

Merged
ClareJonesBJSS merged 7 commits intomainfrom
feature/CCM-12685_validate-submitted-config
Feb 5, 2026
Merged

CCM-12685: Validate routing config submit and move child templates to SUBMITTED#806
ClareJonesBJSS merged 7 commits intomainfrom
feature/CCM-12685_validate-submitted-config

Conversation

@ClareJonesBJSS
Copy link
Contributor

@ClareJonesBJSS ClareJonesBJSS commented Jan 27, 2026

Description

  • Retrieve routing config before submit (implicitly validating name etc via zod parsing)
  • Explicitly check for null defaultTemplateIds
  • Retrieve and validate all referenced templates
  • Move all templates not in a SUBMITTED state to SUBMITTED as part of the txn

Removes the option of null language/accessibility templateIds, as this was not actually being leveraged and getting rid simplifies both this validation and core events

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming
  • If I have used the 'skip-trivy-package' label I have done so responsibly and in the knowledge that this is being fixed as part of a separate ticket/PR.

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@ClareJonesBJSS ClareJonesBJSS requested review from a team as code owners January 27, 2026 17:01
@ClareJonesBJSS ClareJonesBJSS force-pushed the feature/CCM-12685_validate-submitted-config branch 6 times, most recently from 8bab989 to b2f4edc Compare January 28, 2026 09:47
alexnuttall
alexnuttall previously approved these changes Jan 28, 2026
alexnuttall
alexnuttall previously approved these changes Jan 28, 2026
@ClareJonesBJSS ClareJonesBJSS force-pushed the feature/CCM-12685_validate-submitted-config branch from 5bd3af2 to f1ae2d3 Compare February 2, 2026 17:11
alexnuttall
alexnuttall previously approved these changes Feb 3, 2026
@ClareJonesBJSS ClareJonesBJSS force-pushed the feature/CCM-12685_validate-submitted-config branch from 1af9030 to ad7bf1d Compare February 4, 2026 19:21
@ClareJonesBJSS ClareJonesBJSS changed the title CCM-12685: Validate routing config submit CCM-12685: Validate routing config submit and move child templates to SUBMITTED Feb 5, 2026
@ClareJonesBJSS ClareJonesBJSS merged commit 70e0c4c into main Feb 5, 2026
44 checks passed
@ClareJonesBJSS ClareJonesBJSS deleted the feature/CCM-12685_validate-submitted-config branch February 5, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants