CCM-12685: Validate routing config submit and move child templates to SUBMITTED#806
Merged
ClareJonesBJSS merged 7 commits intomainfrom Feb 5, 2026
Merged
Conversation
8bab989 to
b2f4edc
Compare
alexnuttall
reviewed
Jan 28, 2026
infrastructure/terraform/modules/backend-api/module_submit_routing_config_lambda.tf
Show resolved
Hide resolved
alexnuttall
reviewed
Jan 28, 2026
lambdas/backend-api/src/__tests__/infra/routing-config-repository/repository.test.ts
Outdated
Show resolved
Hide resolved
chris-elliott-nhsd
previously approved these changes
Jan 28, 2026
alexnuttall
reviewed
Jan 28, 2026
alexnuttall
reviewed
Jan 28, 2026
lambdas/backend-api/src/infra/routing-config-repository/repository.ts
Outdated
Show resolved
Hide resolved
alexnuttall
previously approved these changes
Jan 28, 2026
d2f1081
alexnuttall
previously approved these changes
Jan 28, 2026
nicki-nhs
reviewed
Jan 28, 2026
lambdas/backend-api/src/infra/routing-config-repository/repository.ts
Outdated
Show resolved
Hide resolved
nicki-nhs
reviewed
Jan 28, 2026
lambdas/backend-api/src/infra/routing-config-repository/repository.ts
Outdated
Show resolved
Hide resolved
nicki-nhs
reviewed
Jan 28, 2026
lambdas/backend-api/src/infra/routing-config-repository/repository.ts
Outdated
Show resolved
Hide resolved
nicki-nhs
reviewed
Jan 28, 2026
lambdas/backend-api/src/infra/routing-config-repository/repository.ts
Outdated
Show resolved
Hide resolved
nicki-nhs
reviewed
Jan 28, 2026
lambdas/backend-api/src/infra/routing-config-repository/repository.ts
Outdated
Show resolved
Hide resolved
nicki-nhs
reviewed
Jan 28, 2026
lambdas/backend-api/src/__tests__/infra/routing-config-repository/repository.test.ts
Outdated
Show resolved
Hide resolved
nicki-nhs
reviewed
Jan 28, 2026
lambdas/backend-api/src/__tests__/infra/routing-config-repository/repository.test.ts
Outdated
Show resolved
Hide resolved
nicki-nhs
reviewed
Jan 28, 2026
lambdas/backend-api/src/__tests__/infra/routing-config-repository/repository.test.ts
Outdated
Show resolved
Hide resolved
nicki-nhs
reviewed
Jan 28, 2026
harrim91
reviewed
Jan 29, 2026
lambdas/backend-api/src/__tests__/infra/routing-config-repository/repository.test.ts
Outdated
Show resolved
Hide resolved
lambdas/backend-api/src/infra/routing-config-repository/repository.ts
Outdated
Show resolved
Hide resolved
lambdas/backend-api/src/infra/routing-config-repository/repository.ts
Outdated
Show resolved
Hide resolved
d2f1081 to
5bd3af2
Compare
5bd3af2 to
f1ae2d3
Compare
alexnuttall
previously approved these changes
Feb 3, 2026
cf16126 to
d055d74
Compare
1af9030 to
ad7bf1d
Compare
mark-r-bjss
approved these changes
Feb 5, 2026
alexnuttall
approved these changes
Feb 5, 2026
harrim91
reviewed
Feb 5, 2026
aidenvaines-cgi
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the option of null language/accessibility templateIds, as this was not actually being leveraged and getting rid simplifies both this validation and core events
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.