Conversation
ExE-Boss
force-pushed
the
rendering
branch
4 times, most recently
from
9cd014b to
0a03a77
Compare
RX14
suggested changes
Jan 19, 2017
docs/Mod Development/Rendering.md
Outdated
| The code above adds a `StaticRenderer` to this object, then creates a `BlockRenderPipeline` for this object with the texture `blockTexture` provided by `YourMod`. After this is done, the `build()` method is called to finish the creation of the rendering pipeline and return a function for rendering the block. | ||
|
|
||
| ## Renderers | ||
| The following are all the renderers you can use in nova. |
Contributor
There was a problem hiding this comment.
What is a renderer? What exactly is it used for?
| components.add(new StaticRenderer().onRender(new BlockRenderPipeline(this).withTexture(YourMod.blockTexture).build()); | ||
| ``` | ||
|
|
||
| The code above adds a `StaticRenderer` to this object, then creates a `BlockRenderPipeline` for this object with the texture `blockTexture` provided by `YourMod`. After this is done, the `build()` method is called to finish the creation of the rendering pipeline and return a function for rendering the block. |
Contributor
There was a problem hiding this comment.
Too abrupt into code without establishing the context.
Member
Author
There was a problem hiding this comment.
Context has been established.
docs/Mod Development/Rendering.md
Outdated
| This is used for rendering providers that redraw the renderer every frame. This renderer should only be reserved for providers which truly need it. | ||
|
|
||
| ## Render pipelines | ||
| Actual rendering is done using pipelines. You can either provide your own, or use any of these pre-built ones. To finish rendering with a pre-built pipeline, you have to call the `build()` method on the instance. |
Contributor
There was a problem hiding this comment.
What is a rendering pipeline? Why is it different from a Renderer? There's no context or concepts just classes thrown at the reader. This isn't javadoc.
RX14
suggested changes
Feb 12, 2017
Contributor
RX14
left a comment
RX14
left a comment
There was a problem hiding this comment.
Still no details on exactly what the split in responsibility is between renderers and pipelines, and why you need both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do: