Enable raster flyer to save asset data#35
Open
vshekar wants to merge 2 commits intoNSLS-II-AMX:mainfrom
Open
Conversation
JunAishima
reviewed
Mar 23, 2026
Contributor
JunAishima
left a comment
There was a problem hiding this comment.
Looking good so far. please keep this PR updated with results of testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the detector arming logic in both
mxtools/flyer.pyandmxtools/raster_flyer.pyto centralize and simplify the configuration of detector parameters. The main changes involve moving repeated logic into a new private method, improving maintainability and consistency between classes, and cleaning up unused or redundant code.Refactoring and centralization of detector arming logic:
_arm_detectormethod inMXFlyerto handle all detector arming and configuration, consolidating logic that was previously duplicated across methods. Thedetector_armmethods in bothMXFlyerandRasterFlyernow delegate to this shared function, passing the appropriate parameters. [1] [2] [3] [4]Code cleanup and removal of unused code:
collect_asset_docsimplementation and theconfigure_detectormethod inRasterFlyer, as well as redundant imports. [1] [2] [3] [4]These changes make the detector configuration process more robust and easier to maintain by reducing code duplication and clarifying the flow of parameter handling.