Conversation
|
| Filename | Overview |
|---|---|
| src/minimizer/bfgs_uff.cpp | New UFF BFGS minimizer; mirrors bfgs_mmff.cpp closely with correct per-molecule vdwThreshold/ignoreInterfrag indexing via confInfo.molIdx. Uses shared bfgs_common infrastructure. No issues found. |
| src/minimizer/bfgs_common.cpp | New shared BFGS infrastructure extracted from bfgs_mmff.cpp. ensureCapacity now uses energiesSize1.3 for the energy buffer (previously used positionsSize1.3), which is a correct improvement. Thread-safety for writeBackResults is preserved. |
| nvmolkit/uffOptimization.py | Python wrapper with solid input validation (None + UFFHasAllMoleculeParams checks) and scalar/sequence normalization. Mirrors mmffOptimization.py structure. No issues found. |
| nvmolkit/boost_python_utils.h | New shared header consolidating previously duplicated vectorToList, vectorOfVectorsToList, extractMolecules, extractDoubleList, extractBoolList helpers from multiple .cpp files. Clean refactoring. |
| nvmolkit/mmff_python_utils.h | New header for MMFF Python utilities. extractMMFFPropertiesList silently fills missing entries with defaults and ignores excess ones — lenient behavior vs. the strict equality check that was previously in mmffOptimization.cpp. Python wrapper always supplies exactly numMols items, so in practice this is benign. |
Reviews (3): Last reviewed commit: "Merge branch 'main' into uff_python" | Re-trigger Greptile
evasnow1992
left a comment
There was a problem hiding this comment.
Changes look good to me. Two minor commends regarding code duplication. Also we are missing updating docs/index.rst and docs/api/nvmolkit.rst with UFF. Would prefer to have them together with the current PR but not required.
|
Updated docs |
No description provided.