Skip to content

ci: Upperbound cvcuda to 0.15#1504

Closed
thomasdhc wants to merge 1 commit intomainfrom
donghyukc/bound_cvcuda
Closed

ci: Upperbound cvcuda to 0.15#1504
thomasdhc wants to merge 1 commit intomainfrom
donghyukc/bound_cvcuda

Conversation

@thomasdhc
Copy link
Copy Markdown
Contributor

Description

Usage

# Add snippet demonstrating usage

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
@thomasdhc thomasdhc added the r1.1.0 Pick this label for auto cherry-picking into r1.1.0 label Feb 13, 2026
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Feb 13, 2026

Greptile Overview

Greptile Summary

This PR adds an upperbound constraint (<=0.15.0) to the cvcuda_cu12 dependency, effectively preventing version 0.16.0 from being installed. The lock file has been updated to pin cvcuda-cu12 to version 0.15.0 (downgraded from 0.16.0).

  • Added upperbound <=0.15.0 to cvcuda_cu12 in the video_cuda12 optional dependency group in pyproject.toml:149
  • Updated uv.lock to reflect cvcuda-cu12==0.15.0 with corresponding wheel hashes

The PR description does not explain why this upperbound is necessary. This could indicate a compatibility issue, breaking API changes, or bug in version 0.16.0 that affects the video processing functionality in nemo_curator/utils/nvcodec_utils.py.

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk, though the lack of explanation for the version constraint is a concern
  • The change is straightforward - adding an upperbound to a dependency. The implementation is correct and the lock file is properly updated. However, the score is not a 5 because: (1) the PR description is incomplete and doesn't explain why this upperbound is necessary, (2) there's no mention of testing to verify the change resolves the issue, and (3) the checklist items are not completed
  • No files require special attention

Important Files Changed

Filename Overview
pyproject.toml Added upperbound <=0.15.0 to cvcuda_cu12 dependency in video_cuda12 optional dependency group
uv.lock Locked cvcuda-cu12 to version 0.15.0 (downgraded from 0.16.0) with updated wheel hashes

Last reviewed commit: 605782b

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Copy link
Copy Markdown
Contributor

@ayushdg ayushdg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this didn't fix it. In addition to this the tests still fail because pycuda has no attribute device

@thomasdhc thomasdhc closed this Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r1.1.0 Pick this label for auto cherry-picking into r1.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants