fix: suppress Claude Code lifecycle noise#213
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (3)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
🧰 Additional context used📓 Path-based instructions (9)**/*.rs📄 CodeRabbit inference engine (.agents/skills/add-binding-feature/SKILL.md)
Files:
**/{Cargo.toml,**/*.rs}📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Files:
**/*.{h,hpp,c,cpp,rs}📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Files:
**/*.{rs,toml}📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Files:
**/*.{rs,py,js,ts,tsx,jsx,go,sh,toml,yaml,yml,md}📄 CodeRabbit inference engine (AGENTS.md)
Files:
**/*.{rs,py,go,js,ts,tsx}📄 CodeRabbit inference engine (AGENTS.md)
Files:
crates/**/*.rs📄 CodeRabbit inference engine (AGENTS.md)
Files:
{crates/adaptive/**/*.rs,**/*test*.{rs,py,go,ts,js},**/*adaptive*test*.{rs,py,go,ts,js},docs/plugins/adaptive/**}📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Files:
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (14)
WalkthroughAdds Claude Code startup-probe detection and a gateway bypass: probes are identified in alignment, classified to bypass managed observability, forwarded directly by the gateway, handled specially in session lifecycle to avoid synthetic turns, and validated by tests and docs. ChangesClaude Code Startup Probe Detection and Bypass
🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsStopped waiting for pipeline failures after 30000ms. One of your pipelines takes longer than our 30000ms fetch window to run, so review may not consider pipeline-failure results for inline comments if any failures occurred after the fetch window. Increase the timeout if you want to wait longer or run a Comment |
github-actions
Bot
added
size:L
AjayThorve
force-pushed
the
ajay/relay-176-claude-observability-contract
branch
from
bbe544f to
4ce112e
Compare
AjayThorve
force-pushed
the
ajay/relay-176-claude-observability-contract
branch
from
4ce112e to
b03f363
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
crates/cli/src/session.rs (1)
969-1007:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPrune bypass-only sessions after the probe finishes.
Line 971 skips
ensure_turn_started, so a brand-new session inserted bySessionManager::prepare_gateway_callcan stay completely empty after the unmanaged probe returns. Nothing inSessionManager::finish_gateway_callremoves that empty entry, so probe-only sessions accumulate inSessionManager::innerand can later be picked bysingle_active_session_id(), miscorrelating headerless gateway traffic.Suggested cleanup
pub(crate) async fn finish_gateway_call(&self, session_id: &str) { let mut sessions = self.inner.lock().await; - if let Some(session) = sessions.get_mut(session_id) { - session.finish_gateway_call(); - } + let should_remove = if let Some(session) = sessions.get_mut(session_id) { + session.finish_gateway_call(); + session.is_empty() + } else { + false + }; + if should_remove { + sessions.remove(session_id); + } }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/cli/src/session.rs` around lines 969 - 1007, The new logic in SessionManager::prepare_gateway_call can create a brand-new, bypass-only session (when gateway_management_policy(&start).bypasses_managed_pipeline() is true) but never removes it, causing empty probe-only sessions to accumulate in SessionManager::inner and later be returned by single_active_session_id(); to fix, record that the session was created as a bypass-only/probe-only session in prepare_gateway_call (e.g., set a flag or marker on the session or in the returned GatewayCallPrep) and then update SessionManager::finish_gateway_call to prune the session if it remains empty after the probe (no turns, no requests, no attributes) — alternatively, detect and remove bypass-only sessions in single_active_session_id() — reference SessionManager::prepare_gateway_call, SessionManager::finish_gateway_call, SessionManager::inner, single_active_session_id(), and GatewayCallPrep when adding the flag/cleanup so the empty probe-only entries are removed immediately after the probe completes.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/cli/tests/coverage/server_tests.rs`:
- Around line 846-864: The subscriber filter is checking for a session_id
metadata field that the LLM span never sets; update the predicate used in
register_subscriber so it matches actual fields emitted by the LLM span (e.g.,
the seeded "gateway_path" value and the correlation fields added by
Session::prepare_gateway_call), not "session_id". Locate the subscriber callback
(the Arc::new move |event| closure in the test) and change the checks to assert
event.name() == "anthropic.messages" and match
event.metadata().and_then(...).and_then(Value::as_str) against the
gateway_path/correlation key(s) produced by build_llm_gateway_start and
Session::prepare_gateway_call so the test only captures real LLM start spans.
In `@crates/cli/tests/coverage/session_tests.rs`:
- Around line 2153-2261: The test registers a global subscriber via
register_subscriber using subscriber_name but never removes it, leaking state;
add a teardown that calls deregister_subscriber(subscriber_name) at the end of
the test (after flush_subscribers() and assertions) to unregister the subscriber
and avoid interference with other tests; reference the existing subscriber_name
variable used with register_subscriber so the teardown targets the same
subscriber (or wrap registration in a scope/Drop helper to ensure deregistration
on test exit).
---
Outside diff comments:
In `@crates/cli/src/session.rs`:
- Around line 969-1007: The new logic in SessionManager::prepare_gateway_call
can create a brand-new, bypass-only session (when
gateway_management_policy(&start).bypasses_managed_pipeline() is true) but never
removes it, causing empty probe-only sessions to accumulate in
SessionManager::inner and later be returned by single_active_session_id(); to
fix, record that the session was created as a bypass-only/probe-only session in
prepare_gateway_call (e.g., set a flag or marker on the session or in the
returned GatewayCallPrep) and then update SessionManager::finish_gateway_call to
prune the session if it remains empty after the probe (no turns, no requests, no
attributes) — alternatively, detect and remove bypass-only sessions in
single_active_session_id() — reference SessionManager::prepare_gateway_call,
SessionManager::finish_gateway_call, SessionManager::inner,
single_active_session_id(), and GatewayCallPrep when adding the flag/cleanup so
the empty probe-only entries are removed immediately after the probe completes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: a5d8c9b5-e51e-49dd-8f68-dee31a9772ee
📒 Files selected for processing (9)
crates/cli/src/alignment/claude_code.rscrates/cli/src/alignment/mod.rscrates/cli/src/gateway.rscrates/cli/src/session.rscrates/cli/tests/coverage/alignment_claude_code_tests.rscrates/cli/tests/coverage/server_tests.rscrates/cli/tests/coverage/session_tests.rsdocs/nemo-relay-cli/claude-code.mdxintegrations/coding-agents/claude-code/README.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Rust / Test (macos-arm64)
- GitHub Check: Rust / Test (windows-arm64)
- GitHub Check: Rust / Test (windows-amd64)
🧰 Additional context used
📓 Path-based instructions (27)
**/*.rs
📄 CodeRabbit inference engine (.agents/skills/add-binding-feature/SKILL.md)
Use
snake_casenaming convention for Rust identifiers (e.g.,nemo_relay_tool_call)
**/*.rs: Any Rust change must runjust test-rust
Any Rust change must runcargo fmt --all
Any Rust change must runcargo clippy --workspace --all-targets -- -D warnings
**/*.rs: Runcargo fmt --allfor all FFI work since it is Rust work
Runjust test-rustto validate FFI changes
Runcargo clippy --workspace --all-targets -- -D warningsto enforce strict linting on FFI workWhen Rust files changed as part of Go work, also run
cargo fmt --all,just test-rust, andcargo clippy --workspace --all-targets -- -D warnings
**/*.rs: Runcargo fmt --allwhen Rust files are changed as part of Node work
Runcargo clippy --workspace --all-targets -- -D warningswhen Rust files are changed as part of Node work
Runjust test-rustwhen Rust files are changed as part of Node work
**/*.rs: Runcargo fmt --allto format all Rust code
Runcargo clippy --workspace --all-targets -- -D warningsto enforce all clippy lints as errors
**/*.rs: Runcargo fmt --allwhen Rust files changed as part of WebAssembly work
Runcargo clippy --workspace --all-targets -- -D warningswhen Rust files changed as part of WebAssembly work
**/*.rs: If any Rust code changed, always runjust test-rust
If any Rust code changed, also runcargo fmt --all
If any Rust code changed, also runcargo clippy --workspace --all-targets -- -D warnings
Run Rust formatting withcargo fmt --all
Run Rust linting withcargo clippy --workspace --all-targets -- -D warnings
**/*.rs: Usecargo fmtfor Rust code formatting
Runcargo clippy -- -D warningsto lint Rust code and treat all warnings as errors
Use Rust snake_case naming convention for Rust identifiers
Include SPDX license header in all Rust source files using double-slash comment syntax
Validate Rust code withuv run pre-commit run --all-filesto enforce cargo fmt formatting check, cargo clippy lints, and cargo deny aud...
Files:
crates/cli/tests/coverage/alignment_claude_code_tests.rscrates/cli/src/alignment/mod.rscrates/cli/src/alignment/claude_code.rscrates/cli/src/gateway.rscrates/cli/tests/coverage/server_tests.rscrates/cli/src/session.rscrates/cli/tests/coverage/session_tests.rs
{crates/adaptive/**/*.rs,**/*test*.{rs,py,go,ts,js},**/*adaptive*test*.{rs,py,go,ts,js},docs/plugins/adaptive/**}
📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)
Maintain documented and tested validation and report behavior for adaptive surfaces
Files:
crates/cli/tests/coverage/alignment_claude_code_tests.rscrates/cli/tests/coverage/server_tests.rscrates/cli/tests/coverage/session_tests.rs
**/{Cargo.toml,**/*.rs}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Maintain consistency between Rust package names in
Cargo.tomland their actual usage across the codebase
Files:
crates/cli/tests/coverage/alignment_claude_code_tests.rscrates/cli/src/alignment/mod.rscrates/cli/src/alignment/claude_code.rscrates/cli/src/gateway.rscrates/cli/tests/coverage/server_tests.rscrates/cli/src/session.rscrates/cli/tests/coverage/session_tests.rs
**/*.{h,hpp,c,cpp,rs}
📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)
Ensure FFI header and library naming follows consistent conventions across platform-specific builds
Files:
crates/cli/tests/coverage/alignment_claude_code_tests.rscrates/cli/src/alignment/mod.rscrates/cli/src/alignment/claude_code.rscrates/cli/src/gateway.rscrates/cli/tests/coverage/server_tests.rscrates/cli/src/session.rscrates/cli/tests/coverage/session_tests.rs
**/*.{rs,toml}
📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Update Rust crate names and module prefixes during coordinated rename operations
Files:
crates/cli/tests/coverage/alignment_claude_code_tests.rscrates/cli/src/alignment/mod.rscrates/cli/src/alignment/claude_code.rscrates/cli/src/gateway.rscrates/cli/tests/coverage/server_tests.rscrates/cli/src/session.rscrates/cli/tests/coverage/session_tests.rs
**/*.{rs,py,js,ts,tsx,jsx,go,sh,toml,yaml,yml,md}
📄 CodeRabbit inference engine (AGENTS.md)
Keep SPDX headers on source, docs, scripts, and configuration files. The project is Apache-2.0.
Files:
crates/cli/tests/coverage/alignment_claude_code_tests.rsintegrations/coding-agents/claude-code/README.mdcrates/cli/src/alignment/mod.rscrates/cli/src/alignment/claude_code.rscrates/cli/src/gateway.rscrates/cli/tests/coverage/server_tests.rscrates/cli/src/session.rscrates/cli/tests/coverage/session_tests.rs
**/*.{rs,py,go,js,ts,tsx}
📄 CodeRabbit inference engine (AGENTS.md)
Follow binding naming conventions: Rust and Python use
snake_case, C FFI exports prefixednemo_relay_, Go usesPascalCasefor public APIs, Node.js usescamelCase.
Files:
crates/cli/tests/coverage/alignment_claude_code_tests.rscrates/cli/src/alignment/mod.rscrates/cli/src/alignment/claude_code.rscrates/cli/src/gateway.rscrates/cli/tests/coverage/server_tests.rscrates/cli/src/session.rscrates/cli/tests/coverage/session_tests.rs
crates/**/*.rs
📄 CodeRabbit inference engine (AGENTS.md)
crates/**/*.rs: Keep async behavior on the existing tokio-based model. Bindings should preserve callback and future lifetimes rather than blocking or hiding async work unexpectedly.
UseJson = serde_json::Valuein Rust-facing runtime APIs for JSON payload handling.
Files:
crates/cli/tests/coverage/alignment_claude_code_tests.rscrates/cli/src/alignment/mod.rscrates/cli/src/alignment/claude_code.rscrates/cli/src/gateway.rscrates/cli/tests/coverage/server_tests.rscrates/cli/src/session.rscrates/cli/tests/coverage/session_tests.rs
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}
⚙️ CodeRabbit configuration file
{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}: Tests should cover the behavior promised by the changed API surface, including error paths and cross-request isolation where relevant.
Prefer assertions on lifecycle events, scope stacks, middleware ordering, and binding parity over shallow smoke tests.
Files:
crates/cli/tests/coverage/alignment_claude_code_tests.rscrates/cli/tests/coverage/server_tests.rscrates/cli/tests/coverage/session_tests.rs
**/*.{md,rst,html,txt}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
**/*.{md,rst,html,txt}: Always spellNVIDIAin all caps. Do not useNvidia,nvidia,nVidia,nVIDIA, orNV.
Usean NVIDIAbefore a noun because the name starts with an 'en' sound.
Do not add a registered trademark symbol afterNVIDIAwhen referring to the company.
Use trademark symbols with product names only when the document type or legal guidance requires them.
Verify official capitalization, spacing, and hyphenation for product names.
Precede NVIDIA product names withNVIDIAon first mention when it is natural and accurate.
Do not rewrite product names for grammar or title-case rules.
Preserve third-party product names according to the owner's spelling.
Include the company name and full model qualifier on first use when it helps identify the model.
Preserve the official capitalization and punctuation of model names.
Use shorter family names only after the full name is established.
Spell out a term on first use and put the acronym in parentheses unless the acronym is widely understood by the intended audience.
Use the acronym on later mentions after it has been defined.
For long documents, reintroduce the full term if readers might lose context.
Form plurals of acronyms withs, not an apostrophe, such asGPUs.
In headings, common acronyms can remain abbreviated. Spell out the term in the first or second sentence of the body.
Common terms such asCPU,GPU,PC,API, andUIusually do not need to be spelled out for developer audiences.
Files:
integrations/coding-agents/claude-code/README.md
**/*.{md,rst,html}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-brand-terminology.md)
Link the first mention of a product name when the destination helps the reader.
Files:
integrations/coding-agents/claude-code/README.md
**/*.md
📄 CodeRabbit inference engine (.agents/skills/contribute-integration/SKILL.md)
Documentation must be updated if activation or usage changed
**/*.md: Use title case consistently in technical documentation headings
Avoid quotation marks, ampersands, and exclamation marks in headings
Keep product, event, research, and whitepaper names in their official title case
Use title case for table headers
Do not force social-media sentence case into technical docs
Format code elements, commands, parameters, package names, and expressions in monospace
Format directories, file names, and paths in monospace using backticks
Use angle brackets inside monospace for variables inside paths, such as/home/<username>/.login
Format error messages and strings in quotation marks, keeping literal code strings in code formatting when clearer
Format UI buttons, menus, fields, and labels in bold
Use angle brackets between UI labels for menu paths, such as File > Save As
Use italics for new terms on first use, sparingly and only when introducing the term
Use italics for publication titles
Format keyboard shortcuts in plain text, such as Press Ctrl+Alt+Delete
Use owner/repo link text for GitHub repositories, preferring[NVIDIA/NeMo](link)over prose references like 'the GitHub repo'
Introduce every code block with a complete sentence
Do not make a code block complete the grammar of the previous sentence
Do not continue a sentence after a code block
Use syntax highlighting when the format supports it for code blocks
Avoid the word 'snippet' unless the surrounding docs already use it as a term of art
Keep inline method, function, and class references consistent with nearby docs, omitting empty parentheses for prose readability when no call is shown
Use descriptive anchor text that matches the destination title when possible for links
Avoid raw URLs in running text
Avoid generic anchor text such as 'here,' 'this page,' and 'read more'
Include acronyms in link text when a linked term includes an acronym
Do not link long sentences or multiple sentences
Avoid links ...
Files:
integrations/coding-agents/claude-code/README.md
**/{docs,examples,**/*.md,*.patch,*.diff,.github,*.sh,*.yaml,*.yml}
📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)
Update documentation, examples, CI configuration, and patch artifacts when performing rename operations
Files:
integrations/coding-agents/claude-code/README.md
**/*.{md,rst,txt}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
Spell
NVIDIAin all caps. Do not useNvidia,nvidia, orNV.
Files:
integrations/coding-agents/claude-code/README.md
**/*.{md,rst}
📄 CodeRabbit inference engine (.agents/skills/review-doc-style/assets/nvidia-style-guide.md)
**/*.{md,rst}: Format commands, code elements, expressions, package names, file names, and paths as inline code.
Use descriptive link text. Avoid raw URLs and weak anchors such as "here" or "read more."
Use title case consistently for technical documentation headings.
Introduce code blocks, lists, tables, and images with complete sentences.
Write procedures as imperative steps. Keep steps parallel and split long procedures into smaller tasks.
Prefer active voice, present tense, short sentences, contractions, and plain English.
Usecanfor possibility and reservemayfor permission.
Useafterfor temporal relationships instead ofonce.
Preferrefer tooverseewhen the wording points readers to another resource.
Avoid culture-specific idioms, unnecessary Latinisms, jokes, and marketing exaggeration in technical docs.
Spell out months in body text, avoid ordinal dates, and use clear time zones.
Spell out whole numbers from zero through nine unless they are technical values, parameters, versions, or UI values.
Use numerals for 10 or greater and include commas in thousands.
Do not add trademark symbols to learning-oriented docs unless the source, platform, or legal guidance explicitly requires them.
Files:
integrations/coding-agents/claude-code/README.md
{docs/**,README.md,CONTRIBUTING.md,**/*.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Run docs link validation with
just docs-linkcheckwhen links change
Files:
integrations/coding-agents/claude-code/README.mddocs/nemo-relay-cli/claude-code.mdx
{docs/**,README.md,**/Cargo.toml,**/package.json,**/*.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Ensure renamed public surfaces are reflected consistently in manifests and docs for large or public-facing changes
Files:
integrations/coding-agents/claude-code/README.mddocs/nemo-relay-cli/claude-code.mdx
**/*.{md,mdx,py,sh,yaml,yml,toml,json}
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
Keep package names, repo references, and build commands current
Files:
integrations/coding-agents/claude-code/README.mddocs/nemo-relay-cli/claude-code.mdx
**/*.{html,md,mdx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Include SPDX license header in HTML and Markdown files using HTML comment syntax
Files:
integrations/coding-agents/claude-code/README.mddocs/nemo-relay-cli/claude-code.mdx
**/README.md
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Update relevant crate or package README when that surface changed
Files:
integrations/coding-agents/claude-code/README.md
{docs/**,README.md,CONTRIBUTING.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
{docs/**,README.md,CONTRIBUTING.md}: For docs-only changes, run targeted checks only if commands, package names, or examples changed. Usejust docsfor docs-site builds andjust docs-linkcheckwhen links changed
Run docs site build withjust docs
Files:
docs/nemo-relay-cli/claude-code.mdx
{docs/**,README.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Verify README and docs entry points still match current package names and paths for large or public-facing changes
Files:
docs/nemo-relay-cli/claude-code.mdx
{docs/**,examples/**,README.md}
📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)
Verify examples still run with documented commands for large or public-facing changes
Files:
docs/nemo-relay-cli/claude-code.mdx
**/*.mdx
📄 CodeRabbit inference engine (.agents/skills/contribute-docs/SKILL.md)
In MDX files, top-of-file comments must use JSX comment delimiters: {/* to open and */} to close. Do not use HTML comments for MDX SPDX headers.
MDX top-of-file SPDX comments must use {/* ... */} delimiters instead of HTML comment delimiters (Must-Fix)
Files:
docs/nemo-relay-cli/claude-code.mdx
docs/**/*.{md,mdx}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Update embedded documentation snippets, patch docs, and binding-support notes if examples or supported bindings changed
Files:
docs/nemo-relay-cli/claude-code.mdx
docs/**
📄 CodeRabbit inference engine (CONTRIBUTING.md)
Run
just docsor./scripts/build-docs.sh htmlto regenerate ignored Fern API reference pages before validation for documentation site changes
Files:
docs/nemo-relay-cli/claude-code.mdx
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}
⚙️ CodeRabbit configuration file
{docs/**,README.md,CONTRIBUTING.md,RELEASING.md,SECURITY.md}: Review documentation for technical accuracy against the current API, command correctness, and consistency across language bindings.
Flag stale examples, missing SPDX headers where required, and instructions that no longer match CI or pre-commit behavior.
Files:
docs/nemo-relay-cli/claude-code.mdx
🔇 Additional comments (6)
crates/cli/src/alignment/claude_code.rs (1)
11-12: LGTM!Also applies to: 31-63
crates/cli/src/alignment/mod.rs (1)
53-73: LGTM!Also applies to: 431-447
crates/cli/tests/coverage/alignment_claude_code_tests.rs (1)
5-7: LGTM!Also applies to: 48-110
docs/nemo-relay-cli/claude-code.mdx (1)
110-117: LGTM!Also applies to: 131-133, 162-177, 179-189
integrations/coding-agents/claude-code/README.md (1)
29-35: LGTM!Also applies to: 137-150, 152-154
crates/cli/tests/coverage/session_tests.rs (1)
2263-2437: LGTM!
Signed-off-by: Ajay Thorve <athorve@nvidia.com>
AjayThorve
force-pushed
the
ajay/relay-176-claude-observability-contract
branch
from
b03f363 to
243e7e1
Compare
Signed-off-by: Ajay Thorve <athorve@nvidia.com>
|
/merge |
2 participants
Overview
Fix Claude Code lifecycle noise that produced synthetic
null,user: test,idle_timeout, or orphan lifecycle-only traces while preserving real per-turn Claude Code spans.Details
SubagentStophooks only when no turn is active; active-turn orphan diagnostics are preserved.Validation run locally:
cargo fmt --allcargo test -p nemo-relay-cli claude -- --nocapturecargo test -p nemo-relay-cli -- --test-threads=1just test-rustcargo clippy --workspace --all-targets -- -D warningsPATH=/Users/athorve/.nvm/versions/node/v23.9.0/bin:$PATH just docsWhere should the reviewer start?
Start with
crates/cli/src/alignment/claude_code.rs, thencrates/cli/src/session.rsandcrates/cli/src/gateway.rs.Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit
New Features
Bug Fixes
Tests
Documentation