Skip to content

test: validate OpenClaw placeholder replay exports#216

Closed
mnajafian-nv wants to merge 2 commits into
NVIDIA:mainfrom
mnajafian-nv:test/openclaw-placeholder-replay-export-validation
Closed

test: validate OpenClaw placeholder replay exports#216
mnajafian-nv wants to merge 2 commits into
NVIDIA:mainfrom
mnajafian-nv:test/openclaw-placeholder-replay-export-validation

Conversation

@mnajafian-nv
Copy link
Copy Markdown
Contributor

@mnajafian-nv mnajafian-nv commented Jun 4, 2026

Overview

This PR adds exporter-visible validation for the OpenClaw placeholder replay fallback shape across ATIF, ATOF, and OpenInference.

  • I confirm this contribution is my own work, or I have the right to submit it under this project's license.
  • I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

  • Adds ATIF validation that OpenClaw placeholder replay preserves an empty user step while keeping the raw replay request in Step.extra.llm_request, including placeholderRequest.
  • Adds ATOF validation that OpenClaw placeholder replay lifecycle payloads are preserved as raw JSONL without inventing higher-fidelity structure.
  • Adds OpenInference validation that OpenClaw placeholder replay falls back to sanitized JSON input.value / input.mime_type and does not invent flattened llm.input_messages.* attributes.
  • Keeps the change test-only and focused on exporter-visible proof of hook-backed OpenClaw fallback behavior.
  • Avoids runtime, adapter, provider-event, or exporter implementation changes in this PR.

Validated with:

  • cargo test -p nemo-relay atif
  • cargo test -p nemo-relay atof
  • cargo test -p nemo-relay openinference
  • cargo fmt --all --check
  • uv run pre-commit run --files crates/core/tests/unit/atif_tests.rs crates/core/tests/unit/observability/atof_tests.rs crates/core/tests/unit/observability/openinference_tests.rs

Where should the reviewer start?

Start in crates/core/tests/unit/observability/openinference_tests.rs for the fallback-shape assertion, then review crates/core/tests/unit/atif_tests.rs for the ATIF empty-user-step and raw-request proof, and crates/core/tests/unit/observability/atof_tests.rs for the raw JSONL preservation check.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • Relates to OpenClaw observability consistency work.

Signed-off-by: mnajafian-nv <mnajafian@nvidia.com>
Signed-off-by: mnajafian-nv <mnajafian@nvidia.com>
@mnajafian-nv mnajafian-nv added this to the 0.4 milestone Jun 4, 2026
@mnajafian-nv mnajafian-nv self-assigned this Jun 4, 2026
@mnajafian-nv mnajafian-nv requested a review from a team as a code owner June 4, 2026 09:31
@github-actions github-actions Bot added size:L PR is large Test Test related lang:rust PR changes/introduces Rust code labels Jun 4, 2026
@mnajafian-nv mnajafian-nv deleted the test/openclaw-placeholder-replay-export-validation branch June 4, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang:rust PR changes/introduces Rust code size:L PR is large Test Test related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant