test: validate OpenClaw placeholder replay exports

[mnajafian-nv]

Overview

It adds exporter-visible validation for OpenClaw placeholder replay fallback behavior across ATIF, ATOF, and OpenInference.

• I confirm this contribution is my own work, or I have the right to submit it under this project's license.
• I searched existing issues and open pull requests, and this does not duplicate existing work.

Details

• Adds ATIF validation that OpenClaw placeholder replay preserves an empty user step while keeping the raw replay request in Step.extra.llm_request, including placeholderRequest.
• Adds ATOF validation that OpenClaw placeholder replay lifecycle payloads are preserved as raw JSONL without inventing higher-fidelity structure.
• Adds OpenInference validation that OpenClaw placeholder replay falls back to sanitized JSON input.value / input.mime_type and does not invent flattened llm.input_messages.* attributes.
• Keeps the change test-only and focused on exporter-visible proof of hook-backed OpenClaw fallback behavior.
• Avoids runtime, adapter, provider-event, or exporter implementation changes in this PR.

Validated with:

• cargo test -p nemo-relay atif
• cargo test -p nemo-relay atof
• cargo test -p nemo-relay openinference
• cargo fmt --all --check
• uv run pre-commit run --files crates/core/tests/unit/atif_tests.rs crates/core/tests/unit/observability/atof_tests.rs crates/core/tests/unit/observability/openinference_tests.rs

Where should the reviewer start?

Start in crates/core/tests/unit/observability/openinference_tests.rs for the fallback-shape assertion, then review crates/core/tests/unit/atif_tests.rs for the ATIF empty-user-step and raw-request proof, and crates/core/tests/unit/observability/atof_tests.rs for the raw JSONL preservation check.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

• Relates to feat: add nested subagent session lineage for OpenClaw #210
• Relates to test: validate OpenClaw nested subagent exports #214
• Relates to OpenClaw observability consistency work.

Summary by CodeRabbit

• Tests
  • Expanded test coverage for OpenClaw placeholder replay scenarios. New tests validate proper handling of replay event payloads, including correct preservation of payload structure and content integrity across multiple exporters and processors, as well as appropriate sanitization of sensitive information (such as authorization headers) in exported replay event data.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Enterprise

Run ID: 326b6928-6c2c-4b76-a2c4-20c817b5cd67

📥 Commits

Reviewing files that changed from the base of the PR and between a653763 and b303a31.

📒 Files selected for processing (3)

• crates/core/tests/unit/atif_tests.rs
• crates/core/tests/unit/observability/atof_tests.rs
• crates/core/tests/unit/observability/openinference_tests.rs

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Check / Run

🧰 Additional context used

📓 Path-based instructions (13)

**/*.rs

📄 CodeRabbit inference engine (.agents/skills/add-binding-feature/SKILL.md)

Use snake_case naming convention for Rust identifiers (e.g., nemo_relay_tool_call)

**/*.rs: Any Rust change must run just test-rust
Any Rust change must run cargo fmt --all
Any Rust change must run cargo clippy --workspace --all-targets -- -D warnings

**/*.rs: Run cargo fmt --all for all FFI work since it is Rust work
Run just test-rust to validate FFI changes
Run cargo clippy --workspace --all-targets -- -D warnings to enforce strict linting on FFI work

When Rust files changed as part of Go work, also run cargo fmt --all, just test-rust, and cargo clippy --workspace --all-targets -- -D warnings

**/*.rs: Run cargo fmt --all when Rust files are changed as part of Node work
Run cargo clippy --workspace --all-targets -- -D warnings when Rust files are changed as part of Node work
Run just test-rust when Rust files are changed as part of Node work

**/*.rs: Run cargo fmt --all to format all Rust code
Run cargo clippy --workspace --all-targets -- -D warnings to enforce all clippy lints as errors

**/*.rs: Run cargo fmt --all when Rust files changed as part of WebAssembly work
Run cargo clippy --workspace --all-targets -- -D warnings when Rust files changed as part of WebAssembly work

**/*.rs: If any Rust code changed, always run just test-rust
If any Rust code changed, also run cargo fmt --all
If any Rust code changed, also run cargo clippy --workspace --all-targets -- -D warnings
Run Rust formatting with cargo fmt --all
Run Rust linting with cargo clippy --workspace --all-targets -- -D warnings

**/*.rs: Use cargo fmt for Rust code formatting
Run cargo clippy -- -D warnings to lint Rust code and treat all warnings as errors
Use Rust snake_case naming convention for Rust identifiers
Include SPDX license header in all Rust source files using double-slash comment syntax
Validate Rust code with uv run pre-commit run --all-files to enforce cargo fmt formatting check, cargo clippy lints, and cargo deny aud...

Files:

• crates/core/tests/unit/observability/atof_tests.rs
• crates/core/tests/unit/observability/openinference_tests.rs
• crates/core/tests/unit/atif_tests.rs

{crates/adaptive/**/*.rs,**/*test*.{rs,py,go,ts,js},**/*adaptive*test*.{rs,py,go,ts,js},docs/plugins/adaptive/**}

📄 CodeRabbit inference engine (.agents/skills/maintain-optimizer/SKILL.md)

Maintain documented and tested validation and report behavior for adaptive surfaces

Files:

• crates/core/tests/unit/observability/atof_tests.rs
• crates/core/tests/unit/observability/openinference_tests.rs
• crates/core/tests/unit/atif_tests.rs

**/{Cargo.toml,**/*.rs}

📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)

Maintain consistency between Rust package names in Cargo.toml and their actual usage across the codebase

Files:

• crates/core/tests/unit/observability/atof_tests.rs
• crates/core/tests/unit/observability/openinference_tests.rs
• crates/core/tests/unit/atif_tests.rs

**/*.{h,hpp,c,cpp,rs}

📄 CodeRabbit inference engine (.agents/skills/maintain-packaging/SKILL.md)

Ensure FFI header and library naming follows consistent conventions across platform-specific builds

Files:

• crates/core/tests/unit/observability/atof_tests.rs
• crates/core/tests/unit/observability/openinference_tests.rs
• crates/core/tests/unit/atif_tests.rs

{crates/core,crates/adaptive}/**/*

📄 CodeRabbit inference engine (.agents/skills/prepare-pr/SKILL.md)

Changes to crates/core or crates/adaptive must run the full language matrix

Files:

• crates/core/tests/unit/observability/atof_tests.rs
• crates/core/tests/unit/observability/openinference_tests.rs
• crates/core/tests/unit/atif_tests.rs

**/*.{rs,toml}

📄 CodeRabbit inference engine (.agents/skills/rename-surfaces/SKILL.md)

Update Rust crate names and module prefixes during coordinated rename operations

Files:

• crates/core/tests/unit/observability/atof_tests.rs
• crates/core/tests/unit/observability/openinference_tests.rs
• crates/core/tests/unit/atif_tests.rs

crates/core/**/*.rs

📄 CodeRabbit inference engine (.agents/skills/test-go-binding/SKILL.md)

If the change touched crates/core or shared runtime semantics, also use validate-change for broader validation

crates/core/**/*.rs: Use Json = serde_json::Value in Rust-facing runtime APIs where the existing code expects JSON payloads.
Use Result<T> with FlowError in core runtime paths. Keep errors explicit and binding-appropriate at the wrapper layer.

Files:

• crates/core/tests/unit/observability/atof_tests.rs
• crates/core/tests/unit/observability/openinference_tests.rs
• crates/core/tests/unit/atif_tests.rs

crates/{core,adaptive}/**

📄 CodeRabbit inference engine (.agents/skills/validate-change/SKILL.md)

If crates/core or crates/adaptive changed, run the full matrix across Rust, Python, Go, Node.js, and WebAssembly

Files:

• crates/core/tests/unit/observability/atof_tests.rs
• crates/core/tests/unit/observability/openinference_tests.rs
• crates/core/tests/unit/atif_tests.rs

**/*.{rs,py,js,ts,tsx,jsx,go,sh,toml,yaml,yml,md}

📄 CodeRabbit inference engine (AGENTS.md)

Keep SPDX headers on source, docs, scripts, and configuration files. The project is Apache-2.0.

Files:

• crates/core/tests/unit/observability/atof_tests.rs
• crates/core/tests/unit/observability/openinference_tests.rs
• crates/core/tests/unit/atif_tests.rs

**/*.{rs,py,go,js,ts,tsx}

📄 CodeRabbit inference engine (AGENTS.md)

Follow binding naming conventions: Rust and Python use snake_case, C FFI exports prefixed nemo_relay_, Go uses PascalCase for public APIs, Node.js uses camelCase.

Files:

• crates/core/tests/unit/observability/atof_tests.rs
• crates/core/tests/unit/observability/openinference_tests.rs
• crates/core/tests/unit/atif_tests.rs

crates/**/*.rs

📄 CodeRabbit inference engine (AGENTS.md)

crates/**/*.rs: Keep async behavior on the existing tokio-based model. Bindings should preserve callback and future lifetimes rather than blocking or hiding async work unexpectedly.
Use Json = serde_json::Value in Rust-facing runtime APIs for JSON payload handling.

Files:

• crates/core/tests/unit/observability/atof_tests.rs
• crates/core/tests/unit/observability/openinference_tests.rs
• crates/core/tests/unit/atif_tests.rs

crates/{core,adaptive}/**/*.rs

⚙️ CodeRabbit configuration file

crates/{core,adaptive}/**/*.rs: Review the Rust runtime for async correctness, scope isolation, middleware ordering, and event lifecycle regressions.
Pay close attention to task-local/thread-local scope propagation, callback lifetimes, stream finalization, and root_uuid isolation.
Public API changes should preserve existing behavior unless tests and docs show the intended migration path.

Files:

• crates/core/tests/unit/observability/atof_tests.rs
• crates/core/tests/unit/observability/openinference_tests.rs
• crates/core/tests/unit/atif_tests.rs

{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}

⚙️ CodeRabbit configuration file

{crates/**/tests/**,python/tests/**,go/nemo_relay/**/*_test.go}: Tests should cover the behavior promised by the changed API surface, including error paths and cross-request isolation where relevant.
Prefer assertions on lifecycle events, scope stacks, middleware ordering, and binding parity over shallow smoke tests.

Files:

• crates/core/tests/unit/observability/atof_tests.rs
• crates/core/tests/unit/observability/openinference_tests.rs
• crates/core/tests/unit/atif_tests.rs

🔇 Additional comments (3)

crates/core/tests/unit/observability/atof_tests.rs (1)

172-198: LGTM!

Also applies to: 601-669

crates/core/tests/unit/observability/openinference_tests.rs (1)

885-957: LGTM!

crates/core/tests/unit/atif_tests.rs (1)

903-974: ⚡ Quick win

Run the required core Rust validation checks (and attach results)

crates/core/tests/unit/atif_tests.rs was modified, so the PR needs the full Rust/core validation matrix: just test-rust, cargo fmt --all, cargo clippy --workspace --all-targets -- -D warnings, and the broader crates/core full matrix across Rust/Python/Go/Node.js/WebAssembly (or CI logs showing these passed).

---

Walkthrough

Three new unit tests are added across observability test files to validate OpenClaw placeholder replay handling. Tests verify that ATIF, ATOF, and OpenInference exporters preserve raw payloads, sanitize sensitive headers, and maintain placeholder request metadata consistently across the observability pipeline.

Changes

OpenClaw placeholder replay observability validation

Layer / File(s)	Summary
ATIF exporter placeholder replay validation crates/core/tests/unit/atif_tests.rs	Test validates that ATIF exporter generates a trajectory with empty user step and preserves the raw llm_request in extra (excluding headers but retaining placeholderRequest and source fields) when processing OpenClaw placeholder replay LLM Start/End events.
ATOF exporter placeholder replay validation crates/core/tests/unit/observability/atof_tests.rs	Test helper constructs OpenClaw replay-style LLM scope events; test verifies that ATOF subscriber exports raw JSONL preserving placeholder request structure, metadata fields (source, hook_event_name), and content payload for both start and end events.
OpenInference exporter placeholder replay validation crates/core/tests/unit/observability/openinference_tests.rs	Test validates that OpenInference event processor emits span attributes with sanitized input.value JSON (headers and authorization/secret removed while preserving placeholder request fields) and expected LLM provider/output fields for OpenClaw placeholder replay scenarios.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• NVIDIA/NeMo-Relay#207: The new OpenInference placeholder replay test directly validates sanitized input.value and flattened attribute behavior for OpenClaw scenarios implemented in that PR's observability changes.
• NVIDIA/NeMo-Relay#203: These tests cover OpenClaw placeholder replay validation across ATIF/ATOF/OpenInference exporters in the same observability contract area.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 75.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	Title follows Conventional Commits format with 'test' type and concise imperative summary under 72 characters.
Description check	✅ Passed	Description includes all required sections (Overview, Details, Where to start, Related Issues) with comprehensive details about test validations and validation commands.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[willkill07]

/merge