refactor(compute): remove legacy host users encoding - #3248
Open
drew wants to merge 3 commits into
Open
Conversation
Closes #2861 Remove the Kubernetes driver fallback for platform_config.host_users and document the typed-only user namespace contract for 0.1.0. Signed-off-by: Drew Newberry <anewberry@nvidia.com>
drew
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 10, 2026 04:49
6 tasks
|
🌿 Preview your docs: https://nvidia-preview-pr-3248.docs.buildwithfern.com/openshell |
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
johntmyers
reviewed
Sep 10, 2026
johntmyers
left a comment
johntmyers
left a comment
Collaborator
There was a problem hiding this comment.
gator-agent
PR Review Status
The code-only review found no blocking implementation defects. The compatibility change is project-valid under maintainer-authored issue #2861, but its required migration and compute-driver compatibility documentation is absent from this patch.
Action required: @drew, please add the migration note and compute-driver compatibility guidance required by #2861, or provide a clear maintainer rationale for why those docs are intentionally unnecessary.
Blocking findings:
- No blocking code findings remain.
Carried findings:
- None.
Gator metadata
- Validation: Maintainer-authored PR implements the focused typed-only user-namespace transition tracked by maintainer-authored issue #2861.
- Docs: Missing for a published compute-driver compatibility and sandbox-behavior change; #2861 explicitly requires migration notes and a compatibility matrix.
- Checks: Current-head Branch Checks, Helm Lint, Trivy Changes, and DCO are green.
- E2E:
test:e2eis required for the Kubernetes driver behavior change, but dispatch waits until review feedback is resolved. - Head SHA:
36951b129091a0e25ee8570b67c1aaa8b4c83ae4 - Base SHA:
a0814443f19c07102b19ff09d6ead3d3ba59f9c5 - Merge base SHA:
a0814443f19c07102b19ff09d6ead3d3ba59f9c5 - Patch ID:
5512eae71db4f8549efa53b74b149c42e38b6bbb - Gator payload:
9 - Review mode:
initial - Previous reviewed SHA: none
- Review budget exhausted: no
- Maintainer decision required: no
- Next state:
gator:in-review
johntmyers
added
the
gator:in-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the Kubernetes compute driver's legacy
platform_config.host_usersfallback so portable user-namespace intent is represented only by typedDriverSandboxTemplate.user_namespaces.Related Issue
Closes #2861
Changes
crates/openshell-driver-kubernetes/src/driver.rs: resolve user namespaces from the typed field or driver default only, remove the unused legacy boolean parser, and enforce that legacy opaque input is ignored.Deviations from Plan
Documentation updates were deferred.
Testing
mise run pre-commitpassesmise run testpasses with the machine's system gateway registry isolated throughOPENSHELL_SYSTEM_GATEWAY_DIRe2e/changedTests added:
platform_config.host_usersis ignored; all six user-namespace tests pass.Checklist