feat(cli): promote profile commands to top level - #3258
Draft
shiju-nv wants to merge 1 commit into
Draft
Conversation
Expose profile discovery and management through openshell profile while retaining the provider list-profiles and provider profile spellings. Add complete catalog pagination and human-readable profile descriptions, with the existing JSON/YAML definition format and workspace selection. Cover both command forms with parser and gateway integration tests, and update profile documentation, skills, examples, and test callers. Refs NVIDIA#2588 Signed-off-by: Shiju <shiju@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Profiles are currently split between
provider list-profilesandprovider profile, with no human-readable view of a single definition. This addsopenshell profilefor discovery and management, includingdescribe, while retaining the existing nested commands through shared handlers.Related Issue
Closes #2588.
Related implementation: #3068. Both proposals support the legacy commands. This proposal additionally implements the requested flat catalog, retrieves all catalog pages, expands description details, and tests the compiled CLI against an isolated gRPC fixture. These additions could also be incorporated into #3068 if maintainers prefer to continue that branch.
Changes
profile list,describe,export,import,update,lint, anddelete, with a validated--type providerfilter for listing.provider list-profilesandprovider profile …, including their arguments, output options, and workspace/global flags. Both entry points use the same execution handlers.NAME / TYPE / CATEGORY / SOURCE / SCOPElist and retrieve every page, including catalogs whose size is an exact multiple of the RPC page limit.Compatibility note: legacy names and flags remain supported, but both list spellings now use the flat human-readable table. The JSON/YAML profile schema is unchanged. Existing import/lint file and directory flags and the update ID/file arguments remain unchanged. No gateway or protobuf API changes are included.
Testing
mise run pre-commitpassesChecklist