fix(ocsf): supply required context in supervisor events - #3287
Closed
krishicks wants to merge 1 commit into
Closed
Conversation
krishicks
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 11, 2026 17:54
|
🌿 Preview your docs: https://nvidia-preview-pr-3287.docs.buildwithfern.com/openshell |
Previously, several supervisor emitters produced Network Activity records without an endpoint or HTTP Activity records without a request or response. OCSF 1.8 requires at least one of each pair, but our schema assertions only checked individually required fields and missed these constraints. Now, proxy connection and accept errors retain the known peer or listening endpoint, metadata HTTP events include their actual response code, and forward scheme rejections include the redacted request. Early authority and credential rejections with only connection context use Network Activity. Unix socket relay and relay-control notifications without network endpoints use Base Event. The NetworkActivityBuilder-to-ConfigStateChangeBuilder replacements cover configuration diagnostics: deprecated TLS settings, invalid credential-signing settings, and overly broad allowed-IP CIDRs. These describe policy configuration, not observed connections, so they should not invent endpoints to fit Network Activity. Bypass-monitor startup failures similarly use Application Lifecycle and identify the monitor separately from the sandbox supervisor. Signed-off-by: Kris Hicks <khicks@nvidia.com>
krishicks
force-pushed
the
hicks/push-qzpplvukovlw
branch
from
September 11, 2026 21:57
eaa6022 to
4fe74f0
Compare
Collaborator
Author
|
I'm going to close this in favor of smaller, targeted PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tl;dr: When doing analysis on the schema downgrade functionality that was recently merged, it was found that we weren't properly adhering to the 1.8 schema. This fixes those issues.
Previously, several supervisor emitters produced Network Activity records without an endpoint or HTTP Activity records without a request or response. OCSF 1.8 requires at least one of each pair, but our schema assertions only checked individually required fields and missed these constraints.
Now, proxy connection and accept errors retain the known peer or listening endpoint, metadata HTTP events include their actual response code, and forward scheme rejections include the redacted request. Early authority and credential rejections with only connection context use Network Activity. Unix socket relay and relay-control notifications without network endpoints use Base Event.
The NetworkActivityBuilder-to-ConfigStateChangeBuilder replacements cover configuration diagnostics: deprecated TLS settings, invalid credential-signing settings, and overly broad allowed-IP CIDRs. These describe policy configuration, not observed connections, so they should not invent endpoints to fit Network Activity. Bypass-monitor startup failures similarly use Application Lifecycle and identify the monitor separately from the sandbox supervisor.
Related Issue
Changes
Testing
mise run pre-commitpassesChecklist