fix(server): prevent deleting providers still referenced by sandboxes…#429
Open
leoshi01 wants to merge 4 commits intoNVIDIA:mainfrom
Open
fix(server): prevent deleting providers still referenced by sandboxes…#429leoshi01 wants to merge 4 commits intoNVIDIA:mainfrom
leoshi01 wants to merge 4 commits intoNVIDIA:mainfrom
Conversation
… or inference routes Block provider deletion when the provider is still referenced by any sandbox (spec.providers) or inference route (inference.local, sandbox-system). Returns FAILED_PRECONDITION with an actionable error message listing the referencing resources. Closes NVIDIA#157
Sandboxes in the Deleting phase still exist in the store but should not block provider deletion since they are already being torn down.
…hint Skip the full sandbox/route scan when the provider does not exist, avoiding unnecessary I/O. Also append an actionable hint to the FAILED_PRECONDITION error message per the issue acceptance criteria.
Collaborator
|
Thanks for the contribution. Our intent is to address referential integrity and data consistency at the data access layer, rather than per entity. This is an effort that we have roadmapped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Block provider deletion when the provider is still referenced by any sandbox (spec.providers) or inference route (inference.local, sandbox-system). Returns FAILED_PRECONDITION with an actionable error message listing the referencing resources.
Closes #157
Summary
Related Issue
Changes
Testing
mise run pre-commitpassesChecklist