fix(e2e): update log-reading helpers for rolling file appender#481
Merged
Conversation
The rolling file appender introduced in PR #431 writes date-stamped files (openshell.YYYY-MM-DD.log) instead of a single openshell.log. Update _read_openshell_log() and _verify_sandbox_functional() to glob for all matching log files so the tests work with both layouts. Signed-off-by: Drew Newberry <anewberry@nvidia.com>
johntmyers
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/var/log/openshell*.log*) instead of reading the hardcoded/var/log/openshell.logpathRelated Issue
Fixes #480
Changes
e2e/python/test_sandbox_policy.py:_read_openshell_log()now usesglob.glob("/var/log/openshell*.log*")to discover and concatenate all rolling log filese2e/python/test_sandbox_policy.py:_verify_sandbox_functional()checks for log file existence via the same glob pattern instead of a hardcoded pathTesting
mise run pre-commitpassesmise run e2e— requires running cluster; the glob pattern matches both the legacy single-file layout and the newopenshell.YYYY-MM-DD.logrolling layoutChecklist
git commit -s)