fix(bootstrap): surface Helm install failure on namespace timeout (#211)#486
Open
Manoj-engineer wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix(bootstrap): surface Helm install failure on namespace timeout (#211)#486Manoj-engineer wants to merge 1 commit intoNVIDIA:mainfrom
Manoj-engineer wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
…IDIA#211) Signed-off-by: Manoj-engineer <194872717+Manoj-engineer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vouched at: #420
Summary
when
gateway starttimes out waiting for theopenshellnamespace, the errormessage now checks for failed
helm-install-*jobs inkube-systemand surfacesthe actual Helm error and last 30 log lines instead of the generic "namespace not ready" message.
Related Issue
Fixes #211
Changes
diagnose_helm_failure()inopenshell-bootstrap/src/lib.rsthat querieshelm-install-*jobs inkube-systemfor failed pods and returns job conditionswait_for_namespace()final timeout branchstatus.failedstays<none>during backoff retry window;filter on
!= "0"instead of!= "<none>" && != "0"to catch actively-failing jobshelm_failure_hint_is_included_in_namespace_timeout_messageTesting
mise run pre-commitpassesserviceaccount.yaml,confirmed the Helm error appears in the terminal output on timeout
Checklist