[Common] Fix Grouped MXFP8 tensor-map validation and synchronization - #3483
Open
Oleg-Goncharov wants to merge 9 commits into
Open
[Common] Fix Grouped MXFP8 tensor-map validation and synchronization#3483Oleg-Goncharov wants to merge 9 commits into
Oleg-Goncharov wants to merge 9 commits into
Conversation
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
for more information, see https://pre-commit.ci
Contributor
Greptile SummaryThe PR fixes Grouped MXFP8 tensor-map validation and safely publishes device-modified TMA descriptors across CTAs.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the descriptor updater now launches a complete warp, reaches the warp-collective publication instruction convergently, and pairs GPU-scope release and acquire operations across updater and consumer CTAs. Important Files Changed
Reviews (3): Last reviewed commit: "[pre-commit.ci] auto fixes from pre-comm..." | Re-trigger Greptile |
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
Signed-off-by: Oleg Goncharov <ogoncharov@nvidia.com>
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two correctness issues in the Grouped MXFP8 quantization kernels introduced by the optimized work mapper.
First, the direct
VARYING_FIRST_DIMpath assumed that every tensor's first dimension was aligned to the 128-row kernel tile, but only the combined logical dimension was validated. This could allow a CTA to cross an expert boundary and use incorrect per-expert metadata.Second, device-modified TMA descriptors were copied from shared to global memory without the release/acquire protocol required by the TMA memory model. The descriptor updater now follows the recommended warp-collective publication sequence.
Addresses #3474
Type of change
Changes
Please list the changes introduced in this PR:
VARYING_FIRST_DIMtensor has a first dimension divisible by the 128-row kernel tile.CUtensorMapstorage to 128 bytes.tensormap.cp_fenceproxyoperation using GPU-scope release semantics.Checklist: