[places] Guard empty tiled mdspan shape size#9149
Open
fallintoplace wants to merge 2 commits into
Open
Conversation
Contributor
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
important: Walkthrough
ChangesEmpty tiled partition size handling
Comment |
Contributor
|
/ok to test 1e2d0c6 |
Contributor
😬 CI Workflow Results🟥 Finished in 1h 03m: Pass: 98%/55 | Total: 1d 00h | Max: 1h 02m | Hits: 12%/168641See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
0early fromtiled_mdspan_shape::size()when the original shape is emptyWhy
tiled_mdspan_shape::size()computestile_per_partand then uses(tile_per_part - 1)in unsigned arithmetic.For empty input,
original_shape.size()is0, sontiles == 0andtile_per_part == 0. That makes(tile_per_part - 1)underflow and can turn an empty shape into a huge nonzero size.Impact
Empty tiled mdspan shapes now report
0elements instead of underflowing.Validation
cmake --preset cudax-cpp17, but validation is blocked in this environment becausenvcc/CUDAToolkitis not available