fix: use pixi-compatible variable syntax in Windows tasks#1793
Open
miyanyan wants to merge 1 commit intoNVIDIA:mainfrom
Open
fix: use pixi-compatible variable syntax in Windows tasks#1793miyanyan wants to merge 1 commit intoNVIDIA:mainfrom
miyanyan wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This updates the Windows
pixitask/env definitions in:cuda_pathfinder/pixi.tomlcuda_bindings/pixi.tomlcuda_core/pixi.tomlIt replaces
cmd.exe-style%VAR%references with$VARsyntax in Windows-specificpixitask and environment entries.Why
pixi runexecutes tasks viadeno_task_shell, notcmd.exeor PowerShell.Because of that, values like
%PIXI_PROJECT_ROOT%are passed through literally instead of being expanded on Windows. That causes commands to fail with errors like: