Skip to content

Add dlpack as a pixi host dependency for cuda_core#1809

Merged
Andy-Jost merged 1 commit intoNVIDIA:mainfrom
Andy-Jost:add-dlpack-host-dep
Mar 23, 2026
Merged

Add dlpack as a pixi host dependency for cuda_core#1809
Andy-Jost merged 1 commit intoNVIDIA:mainfrom
Andy-Jost:add-dlpack-host-dep

Conversation

@Andy-Jost
Copy link
Contributor

@Andy-Jost Andy-Jost commented Mar 23, 2026

Summary

Adds dlpack as a host dependency in cuda_core/pixi.toml so that DLPack headers are available at build time for Cython/C++ compilation. This was introduced as a build requirement by #1687 (TMA TensorMapDescriptor support), which includes <dlpack/dlpack.h> from _cpp/tensor_map.cpp.

Changes

  • cuda_core/pixi.toml: Added dlpack = "*" to [package.host-dependencies]

Test Coverage

Build-only change — verified that pixi install and pip install -v . succeed with the new dependency.

The dlpack package is needed at build time for Cython compilation
of modules that use DLPack interoperability.

Made-with: Cursor
@Andy-Jost Andy-Jost added this to the cuda.core v0.7.0 milestone Mar 23, 2026
@Andy-Jost Andy-Jost added P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Mar 23, 2026
@Andy-Jost Andy-Jost self-assigned this Mar 23, 2026
@Andy-Jost Andy-Jost requested review from cpcloud and rparolin March 23, 2026 18:57
Copy link
Contributor

@cpcloud cpcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Andy-Jost Andy-Jost enabled auto-merge (squash) March 23, 2026 19:33
@Andy-Jost Andy-Jost merged commit cf62591 into NVIDIA:main Mar 23, 2026
67 of 68 checks passed
@Andy-Jost Andy-Jost deleted the add-dlpack-host-dep branch March 23, 2026 20:00
@github-actions
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.core Everything related to the cuda.core module P0 High priority - Must do!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants