Sync test dependencies between pyproject.toml and pixi.toml#1811
Merged
Andy-Jost merged 1 commit intoNVIDIA:mainfrom Mar 23, 2026
Merged
Sync test dependencies between pyproject.toml and pixi.toml#1811Andy-Jost merged 1 commit intoNVIDIA:mainfrom
Andy-Jost merged 1 commit intoNVIDIA:mainfrom
Conversation
Add missing test deps so both dependency surfaces are consistent: - pyproject.toml [dependency-groups] test: add pytest-benchmark, cloudpickle, psutil - pixi.toml [feature.test.dependencies]: add pytest-rerunfailures, cloudpickle, psutil This ensures CI always runs cloudpickle and psutil tests rather than silently skipping them via importorskip. Made-with: Cursor
Andy-Jost
added
P0
|
rwgk
approved these changes
Mar 23, 2026
Collaborator
rwgk
left a comment
rwgk
left a comment
There was a problem hiding this comment.
(For another day: it'd be great to have a pre-commit check that ensures the deps are in sync.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Synchronizes test dependencies between
pyproject.toml[dependency-groups]andpixi.toml[feature.test.dependencies]so both surfaces install the same test tooling. Addscloudpickleandpsutilto ensure CI actually runs the cloudpickle regression tests (#1810) and fd-leak tests rather than silently skipping them viaimportorskip.Changes
cuda_core/pyproject.toml: Addedpytest-benchmark,cloudpickle,psutilto[dependency-groups] testcuda_core/pixi.toml: Addedpytest-rerunfailures,cloudpickle,psutilto[feature.test.dependencies]Test Coverage
No new tests — this ensures existing tests with
importorskipguards run in CI.Companion to #1810.
Made with Cursor