Skip to content

test(cuda.core): restore pyglet context after failed window setup #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwgk merged 3 commits into from
Sep 11, 2026
Merged

test(cuda.core): restore pyglet context after failed window setup #2813

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
510183b
test: restore pyglet context after failed window setup
rluo8 Sep 11, 2026
5161b21
Merge branch 'main' into test/chained-pyglet-gl-setup-failures
rluo8 Sep 11, 2026
9dfdee9
Merge branch 'main' into test/chained-pyglet-gl-setup-failures
rluo8 Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions cuda_core/tests/test_graphics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,13 +61,25 @@ def _configure_pyglet_headless():
def _open_gl_window():
"""Open a hidden window (or configure EGL headless). Returns the window or None.

Closes the window if switch_to() fails so a partially-constructed window does not leak.
Cleans up partial windows and restores the previous GL context if
construction fails. Closes the window if switch_to() fails.
"""
if not pyglet.options.get("headless"):
from pyglet import gl

config = gl.Config(double_buffer=False)
win = pyglet.window.Window(visible=False, config=config)
previous_context = gl.current_context
previous_windows = set(pyglet.app.windows)
try:
win = pyglet.window.Window(visible=False, config=config)
except Exception:
for window in set(pyglet.app.windows) - previous_windows:
with contextlib.suppress(Exception):
window.close()
if previous_context is not None:
with contextlib.suppress(Exception):
previous_context.set_current()
raise
try:
win.switch_to()
except Exception:
Expand Down
Loading