Skip to content

test: centralize Pyglet GL window setup - #2831

Merged
rwgk merged 2 commits into
NVIDIA:mainfrom
rwgk:chained-pyglet-gl-setup-failures-cont
Sep 11, 2026
Merged

test: centralize Pyglet GL window setup#2831
rwgk merged 2 commits into
NVIDIA:mainfrom
rwgk:chained-pyglet-gl-setup-failures-cont

Conversation

@rwgk

@rwgk rwgk commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Description

Follow-up to #2813.

Centralize Pyglet GL window setup in cuda_python_test_helpers.graphics and use it from both the cuda_core and cuda_bindings graphics tests. This shares partial-window cleanup and previous-context restoration across both suites while keeping Pyglet imports lazy so callers can configure headless mode first.

Add one focused regression test covering failed window construction, cleanup of the partial window, and restoration of the previous context.

Testing

  • Changed-file pre-commit checks pass.
  • The focused graphics suites collect 32 tests successfully.
  • The lifecycle regression scenario passes independently.
  • Full GPU test execution is deferred to CI because the local host reports CUDA_ERROR_NO_DEVICE.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes. No documentation changes are needed.

@copy-pr-bot

copy-pr-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module labels Sep 11, 2026
@rwgk rwgk added this to the cuda.core 1.3.0 milestone Sep 11, 2026
@rwgk rwgk added the bug Something isn't working label Sep 11, 2026
@rwgk rwgk self-assigned this Sep 11, 2026
@rwgk

rwgk commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test

@rwgk
rwgk requested a review from juenglin September 11, 2026 16:02
@rwgk
rwgk marked this pull request as ready for review September 11, 2026 16:02
@github-actions

This comment has been minimized.

@rwgk
rwgk enabled auto-merge (squash) September 11, 2026 17:18
@rwgk
rwgk merged commit c143ab3 into NVIDIA:main Sep 11, 2026
120 checks passed
@rwgk

rwgk commented Sep 11, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @mdboom!

@rluo8 for visibility

@rwgk
rwgk deleted the chained-pyglet-gl-setup-failures-cont branch September 11, 2026 17:48
@github-actions

Copy link
Copy Markdown
Contributor
Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cuda.bindings Everything related to the cuda.bindings module cuda.core Everything related to the cuda.core module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants