Skip to content

Fix version guards in tests for set sorted hints - #23703

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
Matt711:bug/polars/set-sorted-hints
Aug 20, 2026
Merged

Fix version guards in tests for set sorted hints#23703
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
Matt711:bug/polars/set-sorted-hints

Conversation

@Matt711

@Matt711 Matt711 commented Aug 18, 2026

Copy link
Copy Markdown
Member

Description

Fix nightly tests https://github.com/NVIDIA/cudf/actions/runs/32106621381/job/95617300260#step:13:4850

FAILED tests/expressions/test_agg.py::test_agg[no_nulls-min-Int32-sorted-in-memory] - polars.exceptions.ComputeError: 'cuda' conversion failed: NotImplementedError: ('Query execution with GPU not possible: unsupported operations.\nThe errors were:\n- NotImplementedError: hint ir', [NotImplementedError('hint ir')])
FAILED tests/expressions/test_agg.py::test_agg[no_nulls-min-Int32-sorted-dask] - polars.exceptions.ComputeError: 'cuda' conversion failed: NotImplementedError: ('Query execution with GPU not possible: unsupported operations.\nThe errors were:\n- NotImplementedError: hint ir', [NotImplementedError('hint ir')])
FAILED tests/expressions/test_agg.py::test_agg[nulls-min-Int32-sorted-spmd-small] - polars.exceptions.ComputeError: 'cuda' conversion failed: NotImplementedError: ('Query execution with GPU not possible: unsupported operations.\nThe errors were:\n- NotImplementedError: hint ir', [NotImplementedError('hint ir')])

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711 Matt711 added bug Something isn't working non-breaking Non-breaking change labels Aug 18, 2026
@copy-pr-bot

copy-pr-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions Bot added Python Affects Python cuDF API. cudf-polars Issues specific to cudf-polars labels Aug 18, 2026
@Matt711

Matt711 commented Aug 18, 2026

Copy link
Copy Markdown
Member Author

/ok to test 61bfc3f

@Matt711
Matt711 marked this pull request as ready for review August 18, 2026 15:49
@Matt711
Matt711 requested a review from a team as a code owner August 18, 2026 15:49
@Matt711
Matt711 requested a review from rjzamora August 18, 2026 15:49
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a5cd5dd6-fdd9-48d8-a30c-809be63c0361

📥 Commits

Reviewing files that changed from the base of the PR and between a98ad61 and 61bfc3f.

📒 Files selected for processing (2)
  • python/cudf_polars/tests/expressions/test_agg.py
  • python/cudf_polars/tests/test_mapfunction.py

Included review availability: Your plan includes up to 12 reviews per rolling hour; 9 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated compatibility handling for Polars versions before 1.38.
    • Adjusted sorted-data and sorted-join test expectations for unsupported sorting hints in older Polars releases.

Walkthrough

The changes update Polars version checks in aggregation and map-function tests. Sorted tests now use the <1.38 compatibility threshold, and the aggregation test records the unsupported set_sorted hint IR as its expected-failure reason.

Changes

Polars compatibility

Layer / File(s) Summary
Sorted test compatibility
python/cudf_polars/tests/expressions/test_agg.py, python/cudf_polars/tests/test_mapfunction.py
Updated version imports and expected-failure conditions for sorted-data and sorted-join tests. The aggregation test now cites unsupported set_sorted hint IR.
Estimated code review effort: 1 (Trivial) ~5 minutes

Merge Risk: ⚪ Minimal · up to 61bfc

This PR makes a localized test-only change to version guards for sorted hints; no actionable merge-blocking risk remains beyond normal checks and review.

Suggested reviewers: mroeschke, madsbk, rjzamora

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: correcting version guards for tests involving sorted hints.
Description check ✅ Passed The description explains the nightly test failures, the unsupported operation, and the follow-up change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Matt711

Matt711 commented Aug 20, 2026

Copy link
Copy Markdown
Member Author

/merge

@rapids-bot
rapids-bot Bot merged commit 1bb00b2 into NVIDIA:main Aug 20, 2026
115 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in cuDF Python Aug 20, 2026
@Matt711
Matt711 deleted the bug/polars/set-sorted-hints branch August 21, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cudf-polars Issues specific to cudf-polars non-breaking Non-breaking change Python Affects Python cuDF API.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants