Skip to content

Pin Cython version for cython-lint pre-commit hook - #23767

Open
Matt711 wants to merge 1 commit into
NVIDIA:mainfrom
Matt711:ci/bug/style-check
Open

Pin Cython version for cython-lint pre-commit hook#23767
Matt711 wants to merge 1 commit into
NVIDIA:mainfrom
Matt711:ci/bug/style-check

Conversation

@Matt711

@Matt711 Matt711 commented Aug 22, 2026

Copy link
Copy Markdown
Member

Description

cython-lint job is currently failing CI. Two things going on:

  1. cython-lint is not compatible with the newest cython release. There's an issue: AttributeError: 'DictComprehensionAppendNode' object has no attribute 'value_expr' with Cython 3.3.0 MarcoGorelli/cython-lint#201
  2. Pinning cython in cudf was not applied everywhere. Everywhere else cython is pinned to >=3.2.2,<3.3.0a0, but the cython-lint doesn't have it. Not sure if that was intentional or an oversight.

If the lack of pinning was an oversight, we can merge this PR regardless of when the cython-lint issue gets fixed and a new release is cut. If not, this should be treated as a temporary workaround. And may not be nescessary at all depending on when the issue is fixed upstream.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@Matt711
Matt711 requested a review from a team as a code owner August 22, 2026 22:02
@Matt711
Matt711 requested a review from msarahan August 22, 2026 22:02
@Matt711 Matt711 added bug Something isn't working non-breaking Non-breaking change labels Aug 22, 2026
@coderabbitai

coderabbitai Bot commented Aug 22, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7827b2d8-d3fe-419b-848b-d0f0bb72f034

📥 Commits

Reviewing files that changed from the base of the PR and between e36fd8a and 67b13ef.

📒 Files selected for processing (1)
  • .pre-commit-config.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the code quality checks to use a newer compatible Cython version range.

Walkthrough

Changes

Lint tooling

Layer / File(s) Summary
Pin cython-lint Cython version
.pre-commit-config.yaml
The cython-lint hook now requires cython>=3.2.2,<3.3.0a0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 67b13

This is a localized pre-commit dependency pin with no actionable merge-blocking risk remaining after normal checks and review.

Suggested reviewers: msarahan, vyasr, bdice

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the Cython version pin for the cython-lint pre-commit hook.
Description check ✅ Passed The description explains the CI failure, upstream incompatibility, and the intended Cython version constraint.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@bdice bdice left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a proper solution until we want to update our Cython pinning across the board.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants