Pin Cython version for cython-lint pre-commit hook - #23767
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughSummary by CodeRabbit
WalkthroughChangesLint tooling
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized pre-commit dependency pin with no actionable merge-blocking risk remaining after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bdice
left a comment
There was a problem hiding this comment.
This seems like a proper solution until we want to update our Cython pinning across the board.
Description
cython-lint job is currently failing CI. Two things going on:
AttributeError: 'DictComprehensionAppendNode' object has no attribute 'value_expr'with Cython3.3.0MarcoGorelli/cython-lint#201If the lack of pinning was an oversight, we can merge this PR regardless of when the cython-lint issue gets fixed and a new release is cut. If not, this should be treated as a temporary workaround. And may not be nescessary at all depending on when the issue is fixed upstream.
Checklist