Skip to content

Improve C ABI struct change error handling #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 2 commits into from
Aug 3, 2026
+10 −2
Merged

Improve C ABI struct change error handling #2386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e2b5f7f
Improve C ABI struct change error handling
jrbourbeau Jul 31, 2026
8f4cbc3
Merge branch 'main' into c-abi-struct-error
cjnolet Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ci/check_c_abi/check_c_abi/abi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#

Expand Down Expand Up @@ -287,6 +287,7 @@ def _analyze_struct_abi(
symbol=name,
location=old_struct.location,
)
continue

for (old_type, old_name), (new_type, new_name) in zip_longest(
old_struct.members,
Expand Down
9 changes: 8 additions & 1 deletion ci/check_c_abi/check_c_abi/tests/test_abi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION.
# SPDX-FileCopyrightText: Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
# SPDX-License-Identifier: Apache-2.0
#

Expand Down Expand Up @@ -65,6 +65,13 @@ def test_struct():
errors = analyze_c_abi(old_abi, old_abi)
assert not errors

# removing a struct should return an error
new_abi = abi_from_str("")
errors = analyze_c_abi(old_abi, new_abi)
assert len(errors) == 1
assert errors[0].symbol == "Foo"
assert errors[0].error == "Struct has been removed"

# removing a field should return an error
new_abi = abi_from_str("""
struct Foo {
Expand Down
Loading