fix: DPU Extension Service status only include used DPUs#2323
Open
hanyux-nv wants to merge 2 commits into
Open
fix: DPU Extension Service status only include used DPUs#2323hanyux-nv wants to merge 2 commits into
hanyux-nv wants to merge 2 commits into
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
|
you might have a conflict, or an error in resolving conflicts. (build failed to compile) |
kensimon
reviewed
Jun 9, 2026
Signed-off-by: Felicity Xu <hanyux@nvidia.com>
df89332 to
ebb4497
Compare
kensimon
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a DPU Extension Service status aggregation nvbug on multi-DPU hosts. Previously, the extension service status aggregation considered every DPU associated with the instance, even when an DPU(secondary DPU) is not being used. As a result, since any unused DPU will never report extension services as
Running, the overall DPU Extension Service status for the instance will not reachRunningeither, preventing instance status from reachingReady.This PR adds filtering to only the DPUs actually used by the instance, which is derived from instance network config using
get_used_dpushelper. Note this filtering is added before:WaitingForExtensionServicesConfigstateBut not before
TerminatedinWaitingForNetworkReconfig, it still checks all DPUs so no change happens there.Also, the DPU agent side has no change. When DPU is not being used, the DPU agent does not deploy any extension services configured for the instance. in which case the agent reports the extension services' status to be "terminated". This is because from the agent's perspective, it cannot tell whether it is not being used and on admin network because 1) has an associated instance but not being configured by tenant, or 2) associated instance is being terminated.
Type of Change
Related Issues (Optional)
Breaking Changes
Testing
Additional Notes