Avoids bug in tensordict==0.12.x by upper-bounding tensordict version#1658
Conversation
… Mesh under torch.compile - Adjusted the tensordict dependency in pyproject.toml to be upper-bounded due to regressions in version 0.12.x, with a note to drop the upper bound once the related PR is merged. - Introduced a new test file for regression testing of the Mesh class to ensure compatibility with torch.compile, specifically addressing issues caused by the tensordict 0.12.x changes. The tests validate that cached properties and data fields behave correctly when compiled.
- Added a new entry in CHANGELOG detailing the fix for constructing a Mesh inside a torch.compile-traced function, addressing regressions from tensordict 0.12.0. - Updated the mlflow and starlette package versions to 3.12.0 and 0.52.1 respectively, along with their corresponding source distribution and wheel URLs. - Adjusted tensordict dependency constraints to ensure compatibility with the latest changes.
tensordict==0.12.x by upper-bounding tensordict version
|
/blossom-ci |
Greptile SummaryThis hotfix pins
Important Files Changed
|
|
/blossom-ci |
|
FYI, |
|
/blossom-ci |
…sion (#1658) * Update tensordict dependency constraints and add regression tests for Mesh under torch.compile - Adjusted the tensordict dependency in pyproject.toml to be upper-bounded due to regressions in version 0.12.x, with a note to drop the upper bound once the related PR is merged. - Introduced a new test file for regression testing of the Mesh class to ensure compatibility with torch.compile, specifically addressing issues caused by the tensordict 0.12.x changes. The tests validate that cached properties and data fields behave correctly when compiled. * Update CHANGELOG and bump mlflow and starlette versions - Added a new entry in CHANGELOG detailing the fix for constructing a Mesh inside a torch.compile-traced function, addressing regressions from tensordict 0.12.0. - Updated the mlflow and starlette package versions to 3.12.0 and 0.52.1 respectively, along with their corresponding source distribution and wheel URLs. - Adjusted tensordict dependency constraints to ensure compatibility with the latest changes. * format
…sion (#1658) * Update tensordict dependency constraints and add regression tests for Mesh under torch.compile - Adjusted the tensordict dependency in pyproject.toml to be upper-bounded due to regressions in version 0.12.x, with a note to drop the upper bound once the related PR is merged. - Introduced a new test file for regression testing of the Mesh class to ensure compatibility with torch.compile, specifically addressing issues caused by the tensordict 0.12.x changes. The tests validate that cached properties and data fields behave correctly when compiled. * Update CHANGELOG and bump mlflow and starlette versions - Added a new entry in CHANGELOG detailing the fix for constructing a Mesh inside a torch.compile-traced function, addressing regressions from tensordict 0.12.0. - Updated the mlflow and starlette package versions to 3.12.0 and 0.52.1 respectively, along with their corresponding source distribution and wheel URLs. - Adjusted tensordict dependency constraints to ensure compatibility with the latest changes. * format
PhysicsNeMo Pull Request
Limits
tensordictupper version to<0.12until the followingtorch.compileregressions are fixed, merged, and released:@tensorclassfield defaults are not applied undertorch.compile, raisingKeyErrorpytorch/tensordict#1710@tensorclasssilently skips__post_init__undertorch.compile, producing wrong output pytorch/tensordict#1708Also adds a test that would have caught this regression earlier.
Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.