fix: Propagate parent_class_enum when it is not the system get_object_properties() and iterate_properties() reject valid properties when parent_class_enum is not System.
#100
+52
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_object_properties() and iterate_properties() reject valid properties when parent_class_enum is not System. The parent_class context was not propagated from iterate_properties() to _validate_properties() to check_property_exists(). Properties valid only within a parent scope (e.g. Emissions.Generators) were incorrectly rejected. Closes #97
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #100 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 8 8
Lines 1688 1688
=======================================
Hits 1607 1607
Misses 81 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hasakev
approved these changes
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent_class context was not propagated from iterate_properties() to _validate_properties() to check_property_exists(). Properties valid only within a parent scope (e.g. Emissions.Generators) were incorrectly rejected.
Closes #97