Skip to content

fix: copy_object and list_objects_by_class#90

Merged
pesap merged 9 commits intoNatLabRockies:mainfrom
akrivi:main
Feb 9, 2026
Merged

fix: copy_object and list_objects_by_class#90
pesap merged 9 commits intoNatLabRockies:mainfrom
akrivi:main

Conversation

@akrivi
Copy link
Collaborator

@akrivi akrivi commented Feb 8, 2026

This PR fixes the following:

  • list_objects_by_class: Filtering objects by category is now correctly implemented.
  • copy_object: Previously, properties were being copied even when copy_properties = false. Also, for the case where copy_properties = true, properties were not copied correctly.
  • _copy_object_properties: Previously, properties associated with scenarios were not copied correctly, leading to missing scenario data on copied objects.
  • copy_object_memberships:
    - It is possible to have objects with memberships where the parent and child objects share the same name but different class. The previous implementation used name-based logic, which caused these memberships to be skipped.
    - Certain Class and Collection names in the db use names with spaces (eg. "ST Schedule", "Head Storage"), while the corresponding Enums use normalized names. Previously, this caused failures when copying memberships for certain objects (eg. Model), since the enum lookup would raise errors. (This is not an issue when using SQL queries)

@akrivi
Copy link
Collaborator Author

akrivi commented Feb 9, 2026

@pesap

@pesap pesap self-requested a review February 9, 2026 17:29
@pesap pesap changed the title Fix copy_object and list_objects_by_class fix: copy_object and list_objects_by_class Feb 9, 2026
@pesap
Copy link
Collaborator

pesap commented Feb 9, 2026

@mcllerena, can you fix the linting/test issues?

@mcllerena
Copy link
Contributor

@mcllerena, can you fix the linting/test issues?

Fixed, @pesap can you check on the run actions/labeler error? I think being a PR from a forked repo is triggering it.

@pesap
Copy link
Collaborator

pesap commented Feb 9, 2026

@mcllerena , we are good to merge! We just need to verify the signature.

@pesap pesap merged commit a11783e into NatLabRockies:main Feb 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants