Repository navigation
Conversation
Fonts: DirectWrite knows no family named serif, sans-serif or monospace, and when nothing matches, SkParagraph falls back to the last font a page registered, so text in an unknown family drew in a web font. On Windows the CSS generics now map to Chrome's defaults (Times New Roman, Arial, Consolas, ...), and Times New Roman, Chrome's standard font, ends every family list. WebGL: texImage2D (both forms) and texSubImage2D passed a WebGPU canvas's GPUCanvasContext itself, which the Node-API binding rejects. They now pass it as a canvas source, as the binding expects. Specs: the offline oscillator expects web-audio-api 1.8.0's normalized square level, as the Node test does since #207. The WebGPU present timing check measures from its first poll, because NativeScript Windows runs timers once a frame, so the first poll can itself land a frame after drawing; a present at the next vsync still fails it.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the canvas spec failures that remained on Windows.
Change
Font fallback (canvas-2d, Windows only). DirectWrite has no family named
serif,sans-seriformonospace, and when no family matches, SkParagraph falls back to the last font the page registered, so text in an unknown family drew in a web font.Font::skia_families()maps the CSS generics to Chrome's Windows defaults (Times New Roman, Arial, Consolas, Comic Sans MS, Impact, Segoe UI) and ends the list with Times New Roman, Chrome's standard font. Other platforms are unchanged.WebGPU canvas as a WebGL texture source (Node-API hosts).
texImage2D(both forms) andtexSubImage2Dpassed a WebGPU canvas's context object itself, which the binding rejects. They now pass it as a canvas source ({ __native__context }), the form the binding takes for WebGPU since #191.Specs
audio: the offline oscillator expects web-audio-api 1.8.0's normalized square level (RMS 0.415), as the Node test has since test(audio): expect the spec-normalized square level from web-audio-api 1.8.0 #207.webgpu.canvaspresent timing: measured from the first poll. NativeScript Windows runs timers once a frame, before the rAF callbacks, so asetTimeout(0)queued in a rAF callback first runs a frame later. The present itself happens in the frame's microtask flush, under a millisecond after drawing. A present at the next vsync still fails the check.Verified
serif,sans-serifandmonospacemeasure as Times New Roman, Arial and Consolas.cargo check -p canvas-2don macOS.