refactor(runtime): consolidate engine backends and harden ownership - #73
Open
DjDeveloperr wants to merge 4 commits into
Open
refactor(runtime): consolidate engine backends and harden ownership#73DjDeveloperr wants to merge 4 commits into
DjDeveloperr wants to merge 4 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DjDeveloperr
marked this pull request as ready for review
August 20, 2026 16:17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The committed range is 396 files, 4,104 insertions, and 86,265 deletions: net -82,161 lines.
Architecture
The Node-API backend remains the ownership/lifecycle reference. Direct backends now use a small shared cleanup registry and shared bridge organization, but engine-native value marshalling stays in the concrete V8, JSC, QuickJS, and Hermes implementations to preserve their faster call paths. Hermes native structs use JSI
NativeStateinstead of a hidden JavaScript property.Memory validation
JSC Node-API previously allocated a new
JSClassReffor every weak reference/wrapper. Sharing one class per info type reduced representative RSS from 278.3 MB to 62.4 MB for wrapper churn and from 162.4 MB to 68.9 MB for mixed stress. The final focused plateau rerun was 49.0 MB.Window-bearing stress tests are excluded by default. They are opt-in with
MEMTEST_WINDOW_TESTS=1, and the AppKit cases construct borderless windows offscreen.Performance
Median microseconds per call, five alternating GSD-on/off runs:
NSDate.doubleisdateWithTimeIntervalSince1970,NSDate.primitiveistimeIntervalSince1970, andNSString.compareiscompareOptions.Direct-engine medians remain comparable to or better than the pre-change baselines. Allocation-heavy
NSDate.dateis noisy in Node-API configurations because finalizer and GC work is included. JSC Node-API's bounded-memory fix intentionally replaces the old leaky allocation behavior; isolated reruns put that case around 111-114 us/call.Android and packaging
host_objectsbridge and both generated dispatch tablesThe aggregate Android Gradle invocation still reaches unrelated Java/Kotlin tasks and fails under the machine's Java 25 installation. Native CMake tasks are green; the repository documents JDK 17 as the supported toolchain.
Artifact audit
node_modules, build directories, or generated package staging