Repository navigation
feat(macos): build arm64-macos and x64-macos V8 slices - #14
Open
edusperoni wants to merge 1 commit into
Open
edusperoni wants to merge 1 commit into
edusperoni wants to merge 1 commit into
Conversation
Adds two macOS variants to the Apple job. They are target_os="mac" with no target_environment, keep the full tier set like Catalyst, and share the rest of the Apple gn args (pointer compression and the cppgc cage off), since every Apple slice is compiled against the same include/ and embedder defines. chrome_pgo_phase=0 is required: is_official_build otherwise makes gn exec a Chromium-only PGO script. The deployment target, 13.3, follows the macOS runtime in NativeScript/runtimes. The slices ship as macos-<cpu>. build-ios.sh --print-slice resolves the dist/ directory and asset stem, and the workflow reads it before the R2 lookup, so a cache hit and a fresh build use the same key. Existing ios-<variant> names and R2 keys are unchanged. The config job now chooses the Apple matrix, so a dispatch with platforms: macos builds only the two macOS slices; every other event builds all nine Apple variants. tests/apple-args.py covers the macOS arguments and every variant's slice name. Supersedes #12, without its Android pointer-compression change, the src-headers closure rewrite, or the manual release_tag input. Co-authored-by: Ammar Ahmed <ammarahmed6506@gmail.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #12, rebuilt on current
mainso it runs with the R2 artifact cache and sccache, and the CI secrets are available. It keeps only the macOS slices.What it adds
arm64-macosandx64-macos, in the Apple job. They usetarget_os="mac"with notarget_environmentand keep the full tier set (not lite mode), like Catalyst.include/with one set of embedder defines (the iOS runtime never definesV8_COMPRESS_POINTERS).chrome_pgo_phase=0is required: on desktop targetsis_official_buildotherwise makes gn exec//tools/update_pgo_profiles.py, which a standalone V8 checkout doesn't have.macos-<cpu>(v8-<version>-macos-arm64.tar.gz), the nameNativeScript/runtimesalready expects from the fork's release.build-ios.sh --print-sliceresolves the name. The workflow reads it before the R2 lookup, so a cache hit and a fresh build use the same key.ios-<variant>assets,dist/dirs and R2 keys don't change.MACOS_DEPLOYMENT_TARGET=13.3, matchingCMAKE_OSX_DEPLOYMENT_TARGETfor macOS inNativeScript/runtimes.configjob now chooses the Apple matrix.platforms: macosbuilds only the two macOS slices,iosbuilds the seven iOS/Catalyst/tvOS variants, and every other event builds all nine. The job is renamedios→apple.tests/apple-args.pycovers the macOS gn args, the iOS args that must not leak into macOS (and vice versa), and every variant's slice name.What's dropped from #12
v8_enable_pointer_compression=falseon Android. The restriction on external memory comes from the sandbox, which is already pinned off. Node-API gatesnapi_no_external_buffers_allowedonV8_ENABLE_SANDBOXonly.NativeScript/androidcompiles with-DV8_COMPRESS_POINTERSon 64-bit, so disabling compression would be an ABI mismatch.NativeScript/runtimescurrently omits that define on Android against the fork's release. It needs to add the define for arm64-v8a/x86_64 when it moves to these releases.release_taginput. As written it could publish a partial release (skipped jobs passed the condition), marked--latest.Verification
python3 tests/apple-args.py: 6 tests pass.gn genforarm64-macosandx64-macosagainst a V8 14.9 checkout succeeds (602 and 1029 targets).V8_OS_MACOSpaths to Catalyst, so it's inert on native macOS.configjob, pending a full run.Co-authored with @ammarahm-ed's #12.