Open
Conversation
- create new modules with /bin/nologin, replacing old default /bin/bash - customize shell of newly added modules with node LOGIN_SHELL enviroment variable - document the new default shell and how to fix existing systems
Contributor
There was a problem hiding this comment.
Pull request overview
This PR changes the default login shell for newly created rootless module Unix users to a non-interactive shell, allows overriding it via an environment variable, and documents how to migrate existing systems accordingly.
Changes:
- Set the default rootless module user shell to
nologinduring module creation, with optional override viaLOGIN_SHELL. - Update documentation to describe the new default shell and provide an upgrade procedure for existing modules.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| docs/modules/rootless_rootfull.md | Documents the new default nologin shell and provides a migration command for existing modules. |
| core/imageroot/var/lib/nethserver/node/actions/add-module/50update | Changes rootless module user creation to default to nologin, with optional LOGIN_SHELL override. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DavidePrincipi
commented
Apr 15, 2026
|
|
||
| id -u | ||
|
|
||
| To protect against system configuration errors, starting with Core 3.20, |
DavidePrincipi
requested review from
Amygos,
Stell0,
andre8244,
gsanchietti,
mrmarkuz and
stephdl
gsanchietti
approved these changes
Apr 15, 2026
Amygos
approved these changes
Apr 15, 2026
mrmarkuz
approved these changes
Apr 15, 2026
andre8244
approved these changes
Apr 16, 2026
Stell0
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs NethServer/dev#7844