Skip to content

dhcpcd: size the escaped-SSID buffers for the worst case #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akiernan wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

dhcpcd: size the escaped-SSID buffers for the worst case #727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/dhcpcd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,7 +628,7 @@ int
dhcpcd_selectprofile(struct interface *ifp, const char *profile)
{
struct if_options *ifo;
char pssid[PROFILE_LEN];
char pssid[(IF_SSIDLEN * 4) + 1];

if (ifp->ssid_len) {
ssize_t r;
Expand Down Expand Up @@ -717,7 +717,7 @@ dhcpcd_initstate(struct interface *ifp, unsigned long long options)
static void
dhcpcd_reportssid(struct interface *ifp)
{
char pssid[IF_SSIDLEN * 4];
char pssid[(IF_SSIDLEN * 4) + 1];

if (print_string(pssid, sizeof(pssid), OT_ESCSTRING, ifp->ssid,
ifp->ssid_len) == -1) {
Expand Down