Skip to content

fix: Enhance LocalePicker dropdown with scroll and max height styling#5681

Open
toviszsolt wants to merge 1 commit into
NginxProxyManager:developfrom
toviszsolt:fix-frontend-locale-dropdown
Open

fix: Enhance LocalePicker dropdown with scroll and max height styling#5681
toviszsolt wants to merge 1 commit into
NginxProxyManager:developfrom
toviszsolt:fix-frontend-locale-dropdown

Conversation

@toviszsolt

Copy link
Copy Markdown
Contributor

Why

The language selector's drop-down menu breaks the layout because there isn't enough vertical space on the screen to display all the languages. The drop-down is now scrollable, based on the official Tabler demo.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • API changes
  • Performance improvement
  • Test addition or update

AI Usage

  • AI was used to write this
  • AI was used to review this

Copilot AI review requested due to automatic review settings June 26, 2026 04:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Improves the LocalePicker language dropdown so it won’t visually overflow limited-height viewports by constraining its height and enabling scrolling within the menu.

Changes:

  • Adds a max-height (50vh) to the dropdown menu container.
  • Attempts to enable vertical scrolling via an added CSS class on the dropdown menu.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread frontend/src/components/LocalePicker.tsx

@toviszsolt toviszsolt left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. This is minor bug fix.

@nginxproxymanagerci

Copy link
Copy Markdown

Docker Image for build 1 is available on DockerHub:

nginxproxymanager/nginx-proxy-manager-dev:pr-5681

Note

Ensure you backup your NPM instance before testing this image! Especially if there are database changes.
This is a different docker image namespace than the official image.

Warning

Changes and additions to DNS Providers require verification by at least 2 members of the community!

Zoey2936 added a commit to ZoeyVid/NPMplus that referenced this pull request Jun 29, 2026
fix: Enhance LocalePicker dropdown with scroll and max height styling NginxProxyManager#5681
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants