nixos/nginx: remove recommendedZstdSettings, add experimental option - #381678
Merged
fpletz merged 1 commit intoJul 16, 2025
Merged
Conversation
github-actions
Bot
added
6.topic: nixos
fpletz
force-pushed
the
nixos/nginx-experimental-zstd-settings
branch
from
February 13, 2025 08:29
8b1ca4f to
f001242
Compare
github-actions
Bot
added
10.rebuild-darwin: 0
This was referenced Feb 13, 2025
fpletz
force-pushed
the
nixos/nginx-experimental-zstd-settings
branch
from
February 13, 2025 09:56
f001242 to
77270af
Compare
ambroisie
added a commit
to ambroisie/nix-config
that referenced
this pull request
Feb 13, 2025
The zstd module is unmaintained and buggy, remove it preventively. The option itself will probably be removed soon [1]. [1]: NixOS/nixpkgs#381678
ambroisie
added a commit
to ambroisie/nix-config
that referenced
this pull request
Feb 13, 2025
The zstd module is unmaintained and buggy, remove it preventively. The option itself will probably be removed soon [1]. [1]: NixOS/nixpkgs#381678
fpletz
force-pushed
the
nixos/nginx-experimental-zstd-settings
branch
from
February 13, 2025 22:55
77b60c7 to
18079b2
Compare
Mic92
reviewed
Feb 26, 2025
wegank
added
the
2.status: merge conflict
Contributor
|
I personally just got stung by this specific issue (pr 23 on the zstd-nginx-module), home assistant's favicon seems to trigger the infinite loop and is really annoying to debug! I didn't understand that the 'recommended' zstd options could have major unfixed bugs like this, like causing my nginx reverse proxy to hang until i kill the worker process. If we are going to keep this as an option, I would suggest we either include |
fpletz
force-pushed
the
nixos/nginx-experimental-zstd-settings
branch
from
July 3, 2025 15:37
18079b2 to
75db741
Compare
Member
Author
|
Rebased and fixed the merge conflict. If there are no further objections, I intend to merge this in a few days. |
The zstd nginx module has known bugs and upstream is currently not maintained. We should not recommend a buggy module and configuration to our users since we are not maintaining the module either.
ofborg
Bot
removed
the
2.status: merge conflict
fpletz
force-pushed
the
nixos/nginx-experimental-zstd-settings
branch
from
July 3, 2025 15:41
75db741 to
db75f90
Compare
| quic_bpf on; | ||
| ''} | ||
|
|
||
| ${optionalString cfg.experimentalZstdSettings '' |
Member
There was a problem hiding this comment.
In line 253 we still have recommendedZstdSettings which will probably break eval and I don't think that the move of the setting was intentional.
13 tasks
pschmitt
added a commit
to pschmitt/nixos-config
that referenced
this pull request
Jul 18, 2025
n0099
added a commit
to n0099/nixos
that referenced
this pull request
Dec 7, 2025
* replace hardcorded value for `home.stateVersion` with current NixOS version * adopt changes of `programs.ssh`: nix-community/home-manager#7655 * adopt changes of `programs.git`: nix-community/home-manager#8006 @ home/n0099.nix * adopt changes of NixOS/nixpkgs#381678 @ default.nix * adopt changes of NixOS/nixpkgs#464333 @ http3.nix @ nginx
n0099
added a commit
to n0099/nixos
that referenced
this pull request
Dec 8, 2025
* replace hardcorded value for `home.stateVersion` with current NixOS version * adopt changes of `programs.ssh`: nix-community/home-manager#7655 * adopt changes of `programs.git`: nix-community/home-manager#8006 @ home/n0099.nix * adopt changes of NixOS/nixpkgs#381678 @ default.nix * adopt changes of NixOS/nixpkgs#464333 @ http3.nix @ nginx
n0099
added a commit
to n0099/nixos
that referenced
this pull request
Dec 8, 2025
* replace hardcorded value for `home.stateVersion` with current NixOS version * adopt changes of `programs.ssh`: nix-community/home-manager#7655 * adopt changes of `programs.git`: nix-community/home-manager#8006 @ home/n0099.nix * adopt changes of NixOS/nixpkgs#381678 @ default.nix * adopt changes of NixOS/nixpkgs#464333 @ http3.nix @ nginx
pschmitt
added a commit
to pschmitt/nixos-config
that referenced
this pull request
Jun 11, 2026
pschmitt
added a commit
to pschmitt/nixos-config
that referenced
this pull request
Jul 21, 2026
pschmitt
added a commit
to pschmitt/nixos-config
that referenced
this pull request
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The zstd nginx module has known bugs and upstream is currently not maintained. We should not recommend a buggy module and configuration to our users since we are not maintaining the module either.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.